Rollup: Consolidate rollup cleanup for http tests #34342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik9000
added
>test
|
Pinging @elastic/es-search-aggs |
|
Note to self and others: we skip the rollup tests using gradle configuration in |
|
This issue tracks the rollup docs tests being disabled: #33319. |
|
@polyfractal, could you have a look at this when you get a chance? I think this is the last thing I need before I can fix the rollup docs tests. |
polyfractal
approved these changes
Oct 16, 2018
|
Thanks for reviewing @polyfractal! I've merged to master and am running the backport tests now. |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Oct 17, 2018
We'd disabled them because we didn't have a way to clean up after each test. I implemented elastic#34342 which adds the clean ups so now we can re-enable the tests. In the `setup` sections we have to use `raw` requests instead of `x-pack` requests because we don't have the json config for x-pack. Closes elastic#33319
nik9000
added a commit
that referenced
this pull request
Oct 17, 2018
This moves the rollup cleanup code for http tests from the high level rest client into the test framework and then entirely removes the rollup cleanup code for http tests that lived in x-pack. This is nice because it consolidates the cleanup into one spot, automatically invokes the cleanup without the test having to know that it is "about rollup", and should allow us to run the rollup docs tests. Part of #34530
|
All backported! |
nik9000
added a commit
that referenced
this pull request
Oct 18, 2018
We'd disabled them because we didn't have a way to clean up after each test. I implemented #34342 which adds the clean ups so now we can re-enable the tests. In the `setup` sections we have to use `raw` requests instead of `x-pack` requests because we don't have the json config for x-pack. Closes #33319
nik9000
added a commit
that referenced
this pull request
Oct 19, 2018
We'd disabled them because we didn't have a way to clean up after each test. I implemented #34342 which adds the clean ups so now we can re-enable the tests. In the `setup` sections we have to use `raw` requests instead of `x-pack` requests because we don't have the json config for x-pack. Closes #33319
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
This moves the rollup cleanup code for http tests from the high level rest client into the test framework and then entirely removes the rollup cleanup code for http tests that lived in x-pack. This is nice because it consolidates the cleanup into one spot, automatically invokes the cleanup without the test having to know that it is "about rollup", and should allow us to run the rollup docs tests. Part of #34530
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
We'd disabled them because we didn't have a way to clean up after each test. I implemented #34342 which adds the clean ups so now we can re-enable the tests. In the `setup` sections we have to use `raw` requests instead of `x-pack` requests because we don't have the json config for x-pack. Closes #33319
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the rollup cleanup code for http tests from the high level rest
client into the test framework and then entirely removes the rollup cleanup
code for http tests that lived in x-pack. This is nice because it
consolidates the cleanup into one spot, automatically invokes the cleanup
without the test having to know that it is "about rollup", and should allow
us to run the rollup docs tests.
Part of #34530