Skip to content

[CI] NodeSubclassTests#testReplaceChildren fails for Pivot #48900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matriv opened this issue Nov 7, 2019 · 12 comments
Closed

[CI] NodeSubclassTests#testReplaceChildren fails for Pivot #48900

matriv opened this issue Nov 7, 2019 · 12 comments
Assignees
@matriv
Labels
:Analytics/SQL SQL querying >test-failure Triaged test failures from CI

Comments

@matriv
Copy link
Contributor

matriv commented Nov 7, 2019

https://gradle-enterprise.elastic.co/s/xyvdtf72vwxka/tests/ihtizrmlhavwa-jrtvjtda2so76

Reproduce (7.x) with:

./gradlew ':x-pack:plugin:sql:test' --tests "org.elasticsearch.xpack.sql.tree.NodeSubclassTests" -Dtests.method="testReplaceChildren {p0=class org.elasticsearch.xpack.sql.plan.logical.Pivot}" -Dtests.seed=6B69CBC6A6A01FE4 -Dtests.security.manager=true -Dtests.locale=th-TH -Dtests.timezone=Pacific/Easter -Dcompiler.java=12 -Druntime.java=8

Stacktrace:


org.elasticsearch.xpack.sql.tree.NodeSubclassTests > testReplaceChildren {p0=class org.elasticsearch.xpack.sql.plan.logical.Pivot} FAILED
--
UnresolvedException[Invalid call to dataType on an unresolved object ?rxWgKl.EFhUf]
at __randomizedtesting.SeedInfo.seed([6B69CBC6A6A01FE4:5296688B5FA63F1A]:0)
at org.elasticsearch.xpack.sql.expression.UnresolvedAttribute.dataType(UnresolvedAttribute.java:79)
at org.elasticsearch.xpack.sql.expression.Attribute.withQualifier(Attribute.java:95)
at org.elasticsearch.xpack.sql.plan.logical.Pivot.withQualifierNull(Pivot.java:47)
at org.elasticsearch.xpack.sql.tree.Node.transformUp(Node.java:190)
at org.elasticsearch.xpack.sql.tree.Node.lambda$transformUp$10(Node.java:188)
at org.elasticsearch.xpack.sql.tree.Node.transformChildren(Node.java:209)
at org.elasticsearch.xpack.sql.tree.Node.transformUp(Node.java:188)
at org.elasticsearch.xpack.sql.plan.logical.Pivot.lambda$replaceChild$0(Pivot.java:70)
at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1382)
at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482)
at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)
at org.elasticsearch.xpack.sql.plan.logical.Pivot.replaceChild(Pivot.java:71)
at org.elasticsearch.xpack.sql.plan.logical.Pivot.replaceChild(Pivot.java:27)
at org.elasticsearch.xpack.sql.plan.logical.UnaryPlan.replaceChildren(UnaryPlan.java:33)
at org.elasticsearch.xpack.sql.plan.logical.UnaryPlan.replaceChildren(UnaryPlan.java:19)
at org.elasticsearch.xpack.sql.tree.NodeSubclassTests.testReplaceChildren(NodeSubclassTests.java:234)
@matriv matriv added >test-failure Triaged test failures from CI :Analytics/SQL SQL querying labels Nov 7, 2019
@matriv matriv self-assigned this Nov 7, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/SQL)

@dnhatn
Copy link
Member

dnhatn commented Nov 9, 2019

Another instance: https://gradle-enterprise.elastic.co/s/5uqrz5ccq45js

@not-napoleon
Copy link
Member

Another: https://gradle-enterprise.elastic.co/s/n7c3wyqq2ofuo/

@romseygeek
Copy link
Contributor

Fails for me on master too with the following reproduce line:

./gradlew ':x-pack:plugin:sql:test' --tests "org.elasticsearch.xpack.sql.tree.NodeSubclassTests" -Dtests.method="testReplaceChildren {p0=class org.elasticsearch.xpack.sql.plan.logical.Pivot}" -Dtests.seed=B778830AC368FB2E -Dtests.security.manager=true -Dtests.locale=ga-IE -Dtests.timezone=Asia/Kuwait

@costin
Copy link
Member

costin commented Nov 12, 2019

More scans detailing the failure:

https://gradle-enterprise.elastic.co/s/ep7cass7ykyii
https://gradle-enterprise.elastic.co/s/zmfddxrllim4c

matriv added a commit to matriv/elasticsearch that referenced this issue Nov 12, 2019
@matriv
SQL: [Tests] Mute testReplaceChildren for Pivot
309e00f 
Temporarily "mute" the testReplaceChildren for Pivot since it leads to
failing tests for some seeds, since the new child doesn't respond to a
valid data type.

Relates to elastic#48900
@matriv matriv mentioned this issue Nov 12, 2019
Closed
matriv added a commit to matriv/elasticsearch that referenced this issue Nov 12, 2019
@matriv
SQL: [Tests] Fix replaceChildren of Pivot
9dce12b 
For the special case that the `qualifier` of an attribute is set to
null, when the attribute is still an `UnresolvedAttribute` there was a
call to `dataType()` which throws an exception. To avoid that the method
`withQualifier()` is overriden for `UnresolvedAttribute`.

Fixes: elastic#48900
@matriv matriv mentioned this issue Nov 12, 2019
Closed
matriv added a commit to matriv/elasticsearch that referenced this issue Nov 13, 2019
@matriv
SQL: [Tests] Mute testReplaceChildren for Pivot
24ef21b 
Temporarily "mute" the testReplaceChildren for Pivot since it leads to
failing tests for some seeds, since the new child doesn't respond to a
valid data type.

Relates to elastic#48900
@matriv matriv mentioned this issue Nov 13, 2019
Merged
@hub-cap
Copy link
Contributor

hub-cap commented Nov 13, 2019

Another today

https://gradle-enterprise.elastic.co/s/r74udmz5mb6tc

@dimitris-athanasiou
Copy link
Contributor

And another one here: https://gradle-enterprise.elastic.co/s/qy5y7uu2a6guy/tests/ihtizrmlhavwa-jrtvjtda2so76?openStackTraces=WzBd

Not sure why we haven't muted this yet. I'll find out if there's a reason and I'll mute it if there's not.

matriv added a commit that referenced this issue Nov 14, 2019
@matriv
SQL: [Tests] Mute testReplaceChildren for Pivot (#49045)
6200a22 
Temporarily "mute" the testReplaceChildren for Pivot since it leads to
failing tests for some seeds, since the new child doesn't respond to a
valid data type.

Relates to #48900
matriv added a commit that referenced this issue Nov 14, 2019
@matriv
SQL: [Tests] Mute testReplaceChildren for Pivot (#49045)
7c3198b 
Temporarily "mute" the testReplaceChildren for Pivot since it leads to
failing tests for some seeds, since the new child doesn't respond to a
valid data type.

Relates to #48900

(cherry picked from commit 6200a22)
@matriv
Copy link
Contributor Author

matriv commented Nov 14, 2019

Muted the test for Pivot in master, 7.x and 7.5.

matriv added a commit that referenced this issue Nov 14, 2019
@matriv
SQL: [Tests] Mute testReplaceChildren for Pivot (#49045)
9a6de86 
Temporarily "mute" the testReplaceChildren for Pivot since it leads to
failing tests for some seeds, since the new child doesn't respond to a
valid data type.

Relates to #48900

(cherry picked from commit 6200a22)
@matriv
Copy link
Contributor Author

matriv commented Dec 6, 2019

Fixed in master (for now) as part of #49693

@matriv
Copy link
Contributor Author

matriv commented Dec 9, 2019

Unmuted the test in master : 4b9b9ed
in 7.x : 48e7420

Didn't unmute for 7.5 since the #49693 refactoring won't be backported there.

@matriv matriv closed this as completed Dec 9, 2019
@przemekwitek
Copy link
Contributor

Reopening as this failed again today:

[6.8.7] https://gradle-enterprise.elastic.co/s/kyjmyf3a7dduc
[7.6.1] https://gradle-enterprise.elastic.co/s/qg6cxf4llg67u
https://gradle-enterprise.elastic.co/s/5zyaahfcoteae

Reproduce lines:

REPRODUCE WITH: gradlew ':x-pack:plugin:sql:test' --tests "org.elasticsearch.xpack.sql.tree.SqlNodeSubclassTests" \
  -Dtests.method="testReplaceChildren {p0=class org.elasticsearch.xpack.ql.expression.predicate.operator.comparison.In}" \
  -Dtests.seed=6CDD4667F032DF98 \
  -Dtests.security.manager=true \
  -Dtests.locale=es-EC \
  -Dtests.timezone=Europe/Gibraltar \
  -Dcompiler.java=13

REPRODUCE WITH: gradlew ':x-pack:plugin:sql:test' --tests "org.elasticsearch.xpack.sql.tree.SqlNodeSubclassTests" \
  -Dtests.method="testReplaceChildren {p0=class org.elasticsearch.xpack.ql.expression.predicate.operator.comparison.In}" \
  -Dtests.seed=6CDD4667F032DF98 \
  -Dtests.security.manager=true \
  -Dtests.locale=es-EC \
  -Dtests.timezone=Europe/Gibraltar \
  -Dcompiler.java=13

Exceprt from logs:

14:58:48 * What went wrong:
14:58:48 Execution failed for task ':x-pack:plugin:sql:test'.
14:58:48 > There were failing tests. See the report at: file:///C:/Users/jenkins/workspace/elastic+elasticsearch+7.x+multijob-windows-compatibility/os/windows-2016/x-pack/plugin/sql/build/reports/tests/test/index.html

@przemekwitek przemekwitek reopened this Mar 2, 2020
@astefan
Copy link
Contributor

astefan commented Mar 2, 2020

@przemekwitek this is the wrong issue. The failure you report is more likely related to #52951.

@astefan astefan closed this as completed Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matriv matriv

Labels
:Analytics/SQL SQL querying >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SQL: [Tests] Fix replaceChildren of Pivot matriv/elasticsearch
10 participants
@costin @hub-cap @astefan @not-napoleon @romseygeek @matriv @dimitris-athanasiou @dnhatn @elasticmachine @przemekwitek