Skip to content

[CI] Autoscaling reference docs Incorrect HTTP method for uri #52050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
albertzaharovits opened this issue Feb 7, 2020 · 9 comments · Fixed by #52088
Closed

[CI] Autoscaling reference docs Incorrect HTTP method for uri #52050

albertzaharovits opened this issue Feb 7, 2020 · 9 comments · Fixed by #52088
Labels

Comments

@albertzaharovits
Copy link
Contributor

java.lang.AssertionError: Failure at [reference/autoscaling/apis/get-autoscaling-decision:11]: expected [2xx] status code but api [raw[method=GET path=_autoscaling/decision/]] returned [405 Method Not Allowed] [{"error":"Incorrect HTTP method for uri [/_autoscaling/decision/?error_trace=true] and method [GET], allowed: [POST]","status":405}] |  

Build stats:
https://gradle-enterprise.elastic.co/s/etiuz357uq37a
https://gradle-enterprise.elastic.co/s/ulirtbaby33yw
https://gradle-enterprise.elastic.co/s/scsxzp5ygfots

cc @jasontedor (because you've recently created these)

@albertzaharovits albertzaharovits added :Core/Infra/Core Core issues without another label >test-failure Triaged test failures from CI labels Feb 7, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Core)

@jasontedor
Copy link
Member

This appears to be an infrastructure problem. The autoscaling docs are not suppose to be included in release docs at this time, yet they are clearly being included here. I think this might relate to #51743, but I’m not sure. Can @nik9000 and @jrodewig help?

@jasontedor jasontedor added :Distributed Coordination/Autoscaling :Docs and removed :Core/Infra/Core Core issues without another label labels Feb 7, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Autoscaling)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (:Docs)

@jrodewig
Copy link
Contributor

jrodewig commented Feb 7, 2020

I can revert #51743, but I don't think it's related.

#51743 should only impact what's included in the HTML output. I believe DocsClientYamlTestSuite picks up any test snippets in the repo's asciidoc files, regardless of whether it's included in the HTML output.

Here's how I tested this locally:

  1. Add a new asciidoc file containing a purposefully broken snippet.
  2. Do not include the asciidoc file in the docbook index or other files.
  3. Run ./gradlew -pdocs check to ensure DocsClientYamlTestSuite failed on the broken snippet test.

If the intent is to skip tests on these snippets for now, we should add a // TEST[skip: ...] comment below the snippet.

@henningandersen
Copy link
Contributor

@jrodewig I think the problem is that change, which now only checks if we are on a release branch or not. But the code checks if we are in a release build and if we are, it does not register the HTTP endpoints.

I think we should only include the docs if we are not on a release branch AND not in a release build.

@jrodewig
Copy link
Contributor

jrodewig commented Feb 7, 2020

@henningandersen I opened #52066 to revert.

@jrodewig
Copy link
Contributor

jrodewig commented Feb 7, 2020

The revert of #52066 has now been merged into master and 7.x. Hopefully, we'll see these clear up now.

I'll work on another way to include the autoscaling and EQL docs as @henningandersen outlined.

Sorry for the noise!

@jasontedor
Copy link
Member

I opened #52088.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants