[DOCS] Display feature flag docs on master, 7.x only #52082
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ability to display docs on permanently unreleased branches, such as `master` and `7.x`. Also updates how the autoscaling and EQL docs are included. Currently, these feature-flag docs would display on any unreleased branches that contain the changes, such as 7.7.
jrodewig
added
>docs
|
Pinging @elastic/es-search (:Search/EQL) |
|
Pinging @elastic/es-docs (:Docs) |
|
Pinging @elastic/es-distributed (:Distributed/Autoscaling) |
jrodewig
commented
Feb 7, 2020
| /////// | ||
| Permanently unreleased branches (master, n.X) | ||
| /////// | ||
| ifeval::["{release-state}"=="unreleased"] |
There was a problem hiding this comment.
This should prevent release build problems we saw with #52050.
|
@henningandersen shared the following command to test release builds: This PR failed those tests. Unfortunately, it seems that this won't solve #52050. |
|
Thanks for trying this. I opened #52088 for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reattempt at #51743. I added some additional logic to target only non-release docs.
Adds the ability to display docs on permanently unreleased branches,
such as
masterand7.x.Also updates how the autoscaling and EQL docs are included. Currently,
these feature-flag docs would display on any unreleased branches that
contain the changes, such as 7.7.