Permit autoscaling feature flag in release builds #52088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit provides a path to set register the autoscaling feature flag in release builds, and therefore enabling autoscaling in release builds. The primary reason that we add this is so that our release docs tests can pass. Our release docs tests do not have infrastructure in place to only register snippets from included portions of the docs, they instead include all docs snippets. Since autoscaling can not be enabled in release builds, this meant that the autoscaling snippets would fail in the release docs tests. To address then, we need the ability to enable autoscaling in the release docs tests which we can now do with the system property added here. This system property will be removed when autoscaling is ready for release.
|
Pinging @elastic/es-distributed (:Distributed/Autoscaling) |
This was referenced Feb 7, 2020
henningandersen
approved these changes
Feb 8, 2020
x-pack/plugin/autoscaling/src/main/java/org/elasticsearch/xpack/autoscaling/Autoscaling.java
Outdated
Show resolved
Hide resolved
jasontedor
commented
Feb 8, 2020
x-pack/plugin/autoscaling/src/main/java/org/elasticsearch/xpack/autoscaling/Autoscaling.java
Outdated
Show resolved
Hide resolved
…k/autoscaling/Autoscaling.java
jasontedor
added a commit
that referenced
this pull request
Feb 8, 2020
This commit provides a path to set register the autoscaling feature flag in release builds, and therefore enabling autoscaling in release builds. The primary reason that we add this is so that our release docs tests can pass. Our release docs tests do not have infrastructure in place to only register snippets from included portions of the docs, they instead include all docs snippets. Since autoscaling can not be enabled in release builds, this meant that the autoscaling snippets would fail in the release docs tests. To address then, we need the ability to enable autoscaling in the release docs tests which we can now do with the system property added here. This system property will be removed when autoscaling is ready for release.
jasontedor
deleted the
autoscaling-feature-flag-in-non-snapshot-builds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit provides a path to set register the autoscaling feature flag in release builds, and therefore enabling autoscaling in release builds. The primary reason that we add this is so that our release docs tests can pass. Our release docs tests do not have infrastructure in place to only register snippets from included portions of the docs, they instead include all docs snippets. Since autoscaling can not be enabled in release builds, this meant that the autoscaling snippets would fail in the release docs tests. To address then, we need the ability to enable autoscaling in the release docs tests which we can now do with the system property added here. This system property will be removed when autoscaling is ready for release.
Closes #52050