Consider node ready on any file settings applied #107738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Readiness is blocked in file based settings having been applied. Yet in the case that an error occurs in a subsequent file based settings update, readiness will stop working. This was unintentional; if file based settings have already been applied once, subsequent failures to apply file based settings should not affect the running system. This commit adjusts the readiness check to consider any file based settings having been applied as allowing the node to be ready.
elasticsearchmachine
added
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Unfortunately |
|
I've disabled the failing test and created #107744 to tackle the issue in a follow up to not block this from getting merged asap. Broken file settings should be an absolutely rare corner case, so this should be fine. |
mosche
approved these changes
Apr 23, 2024
thecoop
approved these changes
Apr 23, 2024
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Apr 23, 2024
If file settings have an update that fails, existing applied file settings continue to work. But if the initial file settings fail to process, readiness should be blocked. This commit adjusts readiness to look for this special initialization case. relates elastic#107738
rjernst
added a commit
that referenced
this pull request
Apr 26, 2024
If file settings have an update that fails, existing applied file settings continue to work. But if the initial file settings fail to process, readiness should be blocked. This commit adjusts readiness to look for this special initialization case. relates #107738
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readiness is blocked in file based settings having been applied. Yet in the case that an error occurs in a subsequent file based settings update, readiness will stop working. This was unintentional; if file based settings have already been applied once, subsequent failures to apply file based settings should not affect the running system.
This commit adjusts the readiness check to consider any file based settings having been applied as allowing the node to be ready.