Skip to content

Enable ingest attachment docs tests on JDK 11 #34770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jasontedor
Copy link
Member

These were disabled because ingest attachement was not playing well with JDK 11. We have addressed that by upgrading the Tika dependency, yet forgot to reenable these. This commit enables these tests again.

Relates #31305

These were disabled because ingest attachement was not playing well with
JDK 11. We have addressed that by upgrading the Tika dependency, yet
forgot to reenable these. This commit enables these tests again.
@jasontedor jasontedor added >test Issues or PRs that are addressing/adding tests :Core/Infra/Core Core issues without another label v7.0.0 jdk11 v6.5.0 labels Oct 23, 2018
@jasontedor jasontedor requested a review from jkakavas October 23, 2018 18:54
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for missing these in #33896

@jasontedor jasontedor merged commit 153157e into elastic:master Oct 25, 2018
jasontedor added a commit that referenced this pull request Oct 25, 2018
These were disabled because ingest attachement was not playing well with
JDK 11. We have addressed that by upgrading the Tika dependency, yet
forgot to reenable these. This commit enables these tests again.
@jasontedor jasontedor deleted the enable-jdk-11-ingest-attachment-docs-tests branch October 25, 2018 03:18
kcm pushed a commit that referenced this pull request Oct 30, 2018
These were disabled because ingest attachement was not playing well with
JDK 11. We have addressed that by upgrading the Tika dependency, yet
forgot to reenable these. This commit enables these tests again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label jdk11 >test Issues or PRs that are addressing/adding tests v6.5.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants