Skip to content

missing 'test2' index example #39055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2019
Merged

missing 'test2' index example #39055

merged 1 commit into from
Feb 20, 2019

Conversation

githubfromgui
Copy link
Contributor

If I got the idea of aliases properly, I think that the index "test2" should have a reference in the example above of the following sentence:

" ... we associate the alias alias1 to both test and test2 ... "

If I got the idea of aliases properly, I think that the index "test2" should have a reference in the example above of the following sentence:

" ... we associate the alias `alias1` to both `test` and `test2` ... "
@colings86 colings86 added the :Data Management/Indices APIs APIs to create and manage indices and templates label Feb 19, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@colings86 colings86 requested a review from talevy February 19, 2019 11:11
@jakelandis jakelandis added the >docs General docs changes label Feb 19, 2019
@talevy
Copy link
Contributor

talevy commented Feb 19, 2019

run elasticsearch-ci/docbldesx

@talevy
Copy link
Contributor

talevy commented Feb 19, 2019

awesome. thank you for this catch @githubfromgui!

I haven't run these tests yet, I have kicked off our CI to verify, but I
would think that line 285 needs to be updated to be:

// TEST[s/^/PUT test\nPUT test2\n/]

@githubfromgui
Copy link
Contributor Author

@talevy that test will be managed by your side, am I right?

@talevy
Copy link
Contributor

talevy commented Feb 20, 2019

yes, it passed the tests! I'll merge this in. thank you for the contribution!

@talevy talevy merged commit 578bfd0 into elastic:6.6 Feb 20, 2019
talevy pushed a commit that referenced this pull request Feb 20, 2019
If I got the idea of aliases properly, I think that the index "test2" should have a reference in the example above of the following sentence:

" ... we associate the alias `alias1` to both `test` and `test2` ... "
talevy added a commit that referenced this pull request Feb 20, 2019
talevy added a commit that referenced this pull request Feb 20, 2019
@talevy
Copy link
Contributor

talevy commented Feb 20, 2019

I forgot to run the other test before I merged. thought I already did

run elasticsearch-ci/default-distro

@talevy
Copy link
Contributor

talevy commented Feb 20, 2019

ah too late. I will fix this on our end. thanks again!

talevy pushed a commit to talevy/elasticsearch that referenced this pull request Feb 20, 2019
If I got the idea of aliases properly, I think that the index "test2" should have a reference in the example above of the following sentence:

" ... we associate the alias `alias1` to both `test` and `test2` ... "
talevy added a commit that referenced this pull request Feb 21, 2019
* missing 'test2' index example (#39055)

If I got the idea of aliases properly, I think that the index "test2" should have a reference in the example above of the following sentence:

" ... we associate the alias `alias1` to both `test` and `test2` ... "

* add PUT test2

* Update aliases.asciidoc

swap which is write/read
talevy added a commit to talevy/elasticsearch that referenced this pull request Feb 21, 2019
* missing 'test2' index example (elastic#39055)

If I got the idea of aliases properly, I think that the index "test2" should have a reference in the example above of the following sentence:

" ... we associate the alias `alias1` to both `test` and `test2` ... "

* add PUT test2

* Update aliases.asciidoc

swap which is write/read
talevy added a commit to talevy/elasticsearch that referenced this pull request Feb 21, 2019
* missing 'test2' index example (elastic#39055)

If I got the idea of aliases properly, I think that the index "test2" should have a reference in the example above of the following sentence:

" ... we associate the alias `alias1` to both `test` and `test2` ... "

* add PUT test2

* Update aliases.asciidoc

swap which is write/read
talevy added a commit to talevy/elasticsearch that referenced this pull request Feb 21, 2019
* missing 'test2' index example (elastic#39055)

If I got the idea of aliases properly, I think that the index "test2" should have a reference in the example above of the following sentence:

" ... we associate the alias `alias1` to both `test` and `test2` ... "

* add PUT test2

* Update aliases.asciidoc

swap which is write/read
talevy added a commit to talevy/elasticsearch that referenced this pull request Feb 21, 2019
* missing 'test2' index example (elastic#39055)

If I got the idea of aliases properly, I think that the index "test2" should have a reference in the example above of the following sentence:

" ... we associate the alias `alias1` to both `test` and `test2` ... "

* add PUT test2

* Update aliases.asciidoc

swap which is write/read
talevy added a commit that referenced this pull request Feb 21, 2019
* missing 'test2' index example (#39055)

If I got the idea of aliases properly, I think that the index "test2" should have
a reference in the example above of the following sentence:

" ... we associate the alias `alias1` to both `test` and `test2` ... "

* add PUT test2

* Update aliases.asciidoc

swap which is write/read

Co-authored-by: Guilherme Ferreira <[email protected]>
talevy added a commit that referenced this pull request Feb 21, 2019
* missing 'test2' index example (#39055)

If I got the idea of aliases properly, I think that the index "test2" should have a 
reference in the example above of the following sentence:

" ... we associate the alias `alias1` to both `test` and `test2` ... "

* add PUT test2

* Update aliases.asciidoc

swap which is write/read

Co-authored-by: Guilherme Ferreira <[email protected]>
talevy added a commit that referenced this pull request Feb 21, 2019
* missing 'test2' index example (#39055)

If I got the idea of aliases properly, I think that the index "test2" should have 
a reference in the example above of the following sentence:

" ... we associate the alias `alias1` to both `test` and `test2` ... "

* add PUT test2

* Update aliases.asciidoc

swap which is write/read

Co-authored-by: Guilherme Ferreira <[email protected]>
talevy added a commit that referenced this pull request Feb 21, 2019
* missing 'test2' index example (#39055)

If I got the idea of aliases properly, I think that the index "test2" should have 
a reference in the example above of the following sentence:

" ... we associate the alias `alias1` to both `test` and `test2` ... "

* add PUT test2

* Update aliases.asciidoc

swap which is write/read

Co-authored-by: Guilherme Ferreira <[email protected]>
weizijun pushed a commit to weizijun/elasticsearch that referenced this pull request Feb 22, 2019
* missing 'test2' index example (elastic#39055)

If I got the idea of aliases properly, I think that the index "test2" should have a reference in the example above of the following sentence:

" ... we associate the alias `alias1` to both `test` and `test2` ... "

* add PUT test2

* Update aliases.asciidoc

swap which is write/read
weizijun pushed a commit to weizijun/elasticsearch that referenced this pull request Feb 22, 2019
* missing 'test2' index example (elastic#39055)

If I got the idea of aliases properly, I think that the index "test2" should have a reference in the example above of the following sentence:

" ... we associate the alias `alias1` to both `test` and `test2` ... "

* add PUT test2

* Update aliases.asciidoc

swap which is write/read
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates >docs General docs changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants