add missing test2 index in alias example
#39212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If I got the idea of aliases properly, I think that the index "test2" should have a reference in the example above of the following sentence: " ... we associate the alias `alias1` to both `test` and `test2` ... "
talevy
added
>docs
|
Pinging @elastic/es-core-features |
jtibshirani
reviewed
Feb 20, 2019
| } | ||
| ] | ||
| } | ||
| -------------------------------------------------- | ||
| // CONSOLE | ||
| // TEST[s/^/PUT test\n/] | ||
| // TEST[s/^/PUT test\nPUT test2\n/] | ||
|
|
||
| In this example, we associate the alias `alias1` to both `test` and `test2`, where |
There was a problem hiding this comment.
Reading the rest of this example, I think the final section may be incorrect as well:
To swap which index is the write index for an alias, the Aliases API can be leveraged to
do an atomic swap. The swap is not dependent on the ordering of the actions.
POST /_aliases
{
"actions" : [
{
"add" : {
"index" : "test",
"alias" : "alias1",
"is_write_index" : true
}
}, {
"add" : {
"index" : "test2",
"alias" : "alias1",
"is_write_index" : false
}
}
]
}
Given the description, it seems like the boolean values for is_write_index should be flipped. I think it'd be nice to fix that in this PR as well, if you also think that's reasonable?
There was a problem hiding this comment.
ah, I see. I think, when writing the docs, this was meant to be thought of as a separate example. Now I see that it feels like a continuation of the previous
swap which is write/read
|
thanks Julie, updated! |
|
thanks! |
talevy
added a commit
to talevy/elasticsearch
that referenced
this pull request
Feb 21, 2019
* missing 'test2' index example (elastic#39055) If I got the idea of aliases properly, I think that the index "test2" should have a reference in the example above of the following sentence: " ... we associate the alias `alias1` to both `test` and `test2` ... " * add PUT test2 * Update aliases.asciidoc swap which is write/read
talevy
added a commit
to talevy/elasticsearch
that referenced
this pull request
Feb 21, 2019
* missing 'test2' index example (elastic#39055) If I got the idea of aliases properly, I think that the index "test2" should have a reference in the example above of the following sentence: " ... we associate the alias `alias1` to both `test` and `test2` ... " * add PUT test2 * Update aliases.asciidoc swap which is write/read
talevy
added a commit
to talevy/elasticsearch
that referenced
this pull request
Feb 21, 2019
* missing 'test2' index example (elastic#39055) If I got the idea of aliases properly, I think that the index "test2" should have a reference in the example above of the following sentence: " ... we associate the alias `alias1` to both `test` and `test2` ... " * add PUT test2 * Update aliases.asciidoc swap which is write/read
talevy
added a commit
to talevy/elasticsearch
that referenced
this pull request
Feb 21, 2019
* missing 'test2' index example (elastic#39055) If I got the idea of aliases properly, I think that the index "test2" should have a reference in the example above of the following sentence: " ... we associate the alias `alias1` to both `test` and `test2` ... " * add PUT test2 * Update aliases.asciidoc swap which is write/read
talevy
added a commit
that referenced
this pull request
Feb 21, 2019
* missing 'test2' index example (#39055) If I got the idea of aliases properly, I think that the index "test2" should have a reference in the example above of the following sentence: " ... we associate the alias `alias1` to both `test` and `test2` ... " * add PUT test2 * Update aliases.asciidoc swap which is write/read Co-authored-by: Guilherme Ferreira <[email protected]>
talevy
added a commit
that referenced
this pull request
Feb 21, 2019
* missing 'test2' index example (#39055) If I got the idea of aliases properly, I think that the index "test2" should have a reference in the example above of the following sentence: " ... we associate the alias `alias1` to both `test` and `test2` ... " * add PUT test2 * Update aliases.asciidoc swap which is write/read Co-authored-by: Guilherme Ferreira <[email protected]>
talevy
added a commit
that referenced
this pull request
Feb 21, 2019
* missing 'test2' index example (#39055) If I got the idea of aliases properly, I think that the index "test2" should have a reference in the example above of the following sentence: " ... we associate the alias `alias1` to both `test` and `test2` ... " * add PUT test2 * Update aliases.asciidoc swap which is write/read Co-authored-by: Guilherme Ferreira <[email protected]>
talevy
added a commit
that referenced
this pull request
Feb 21, 2019
* missing 'test2' index example (#39055) If I got the idea of aliases properly, I think that the index "test2" should have a reference in the example above of the following sentence: " ... we associate the alias `alias1` to both `test` and `test2` ... " * add PUT test2 * Update aliases.asciidoc swap which is write/read Co-authored-by: Guilherme Ferreira <[email protected]>
weizijun
pushed a commit
to weizijun/elasticsearch
that referenced
this pull request
Feb 22, 2019
* missing 'test2' index example (elastic#39055) If I got the idea of aliases properly, I think that the index "test2" should have a reference in the example above of the following sentence: " ... we associate the alias `alias1` to both `test` and `test2` ... " * add PUT test2 * Update aliases.asciidoc swap which is write/read
weizijun
pushed a commit
to weizijun/elasticsearch
that referenced
this pull request
Feb 22, 2019
* missing 'test2' index example (elastic#39055) If I got the idea of aliases properly, I think that the index "test2" should have a reference in the example above of the following sentence: " ... we associate the alias `alias1` to both `test` and `test2` ... " * add PUT test2 * Update aliases.asciidoc swap which is write/read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from original PR:
this PR re-applies #39055. That PR was prematurely merged with a failing test.