Add xpack.eql.enabled feature flag, disabled by default. Enabled for gradle run task and integration tests. #51370
Conversation
…gradle run task and integration tests.
aleksmaus
force-pushed
the
feature/eql_feature_flag
branch
from
faca844 to
68f09e3
Compare
There was a problem hiding this comment.
Left a small comment about enabling it by default in run. Not sure if we should enable it in run at all. @colings86 what do you think? Otherwise looks good to me.
distribution/build.gradle
Outdated
| @@ -422,6 +422,7 @@ testClusters { | |||
| if (System.getProperty('run.distribution', 'default') == 'default') { | |||
| String licenseType = System.getProperty("run.license_type", "basic") | |||
| if (licenseType == 'trial') { | |||
| setting 'xpack.eql.enabled', 'true' | |||
There was a problem hiding this comment.
We enable it here only for trial, but we run integration tests under basic. That doesn't seem to be consistent. I would just put next to pack.sql.enabled until we figure out what to do with it.
There was a problem hiding this comment.
Updated to enable consistently with sql plugin for run task, seems logical.
|
Thought it would be convenient for development to have this enabled for gradle run task, especially since this is already done for sql plugin. |
|
on mobile so maybe missing something... We should definitely have it enabled for the tests in the EQL module but not sure we need it enabled for all tests. We don’t do that for security AFAIK @jasontedor what are you doing for Autoscaling? Just enable it in the Autoscaling tests? |
|
Oh I see we actually do it for security sorry. However I think we should match Autoscaling while it’s in development |
|
@colings86 We are only going to enable it where it's required in autoscaling tests. I don't think these should be enabled in |
|
Pinging @elastic/es-search (:Search/EQL) |
… for integration tests. (elastic#51370) Related to elastic#49581
Related to #49581