-
Notifications
You must be signed in to change notification settings - Fork 25.2k
EQL: Backport to 7.x #51502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
EQL: Backport to 7.x #51502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors EqlSearchResponse to make it immutable Relates to elastic#49581
Removes unnecessary classes from EqlSearchResponse that just represent lists of other elements. Relates to elastic#49581
…#50925) Replaces the existing hand-build Hits parser with a ConstructingObjectParser version. Relates to elastic#49581
Link QL into the new build file Remove duplicate classes and use the new ql package Update Exception hierarchy on top of QlException
… for integration tests. (elastic#51370) Related to elastic#49581
Pinging @elastic/es-search (:Search/EQL) |
costin
approved these changes
Jan 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged locally and pushed to 7.x to preserve history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following commits were cherry picked from feature/eql branch for backport to 7.x
The extra commit to fix some incompatibilities between master and 7.x branch.
Please check that I didn't miss anything.
Thanks!