-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Introduce system index APIs for Kibana #53035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a module for Kibana that exposes REST APIs that will be used by Kibana for access to its system indices. These APIs are wrapped versions of the existing REST endpoints. A new setting is also introduced since the Kibana system indices' names are allowed to be changed by a user in case multiple instances of Kibana use the same instance of Elasticsearch. Additionally, the ThreadContext has been extended to indicate that the use of system indices may be allowed in a request. This will be built upon in the future for the protection of system indices. Backport of elastic#52385
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
jaymode
added a commit
to jaymode/elasticsearch
that referenced
this pull request
Mar 3, 2020
The system index module for Kibana has been merged to master in elastic#52385 and is being backported to 7.x in elastic#53035, which requires changes to the serialization version. In order to avoid build failures, this commit disables bwc tests. A subsequent commit will reenable these tests.
jaymode
added a commit
to jaymode/elasticsearch
that referenced
this pull request
Mar 3, 2020
This commit updates the serialization for allowed system indices after the backport of the work and also re-enables bwc compatibility tests. Relates elastic#52385 Relates elastic#53035 Relates elastic#53062
jaymode
added a commit
that referenced
this pull request
Mar 4, 2020
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Mar 21, 2020
This reverts commit c610e08. backport of elastic#53912
rjernst
added a commit
that referenced
this pull request
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a module for Kibana that exposes REST APIs that
will be used by Kibana for access to its system indices. These APIs are wrapped
versions of the existing REST endpoints. A new setting is also introduced since
the Kibana system indices' names are allowed to be changed by a user in case
multiple instances of Kibana use the same instance of Elasticsearch.
Additionally, the ThreadContext has been extended to indicate that the use of
system indices may be allowed in a request. This will be built upon in the future
for the protection of system indices.
Backport of #52385