-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Revert "Introduce system index APIs for Kibana (#52385)" #53912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rjernst
merged 4 commits into
elastic:master
from
rjernst:revert_system_indices_threadcontext
Mar 23, 2020
Merged
Revert "Introduce system index APIs for Kibana (#52385)" #53912
rjernst
merged 4 commits into
elastic:master
from
rjernst:revert_system_indices_threadcontext
Mar 23, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4c0e8f1. It should be re-added once elastic#53909 is addressed.
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Mar 21, 2020
This reverts commit c610e08. backport of elastic#53912
pugnascotia
approved these changes
Mar 23, 2020
Thanks for this @rjernst |
rjernst
added a commit
that referenced
this pull request
Mar 23, 2020
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Mar 23, 2020
rjernst
added a commit
that referenced
this pull request
Mar 23, 2020
jaymode
added a commit
to jaymode/elasticsearch
that referenced
this pull request
Apr 7, 2020
This change reintroduces the system index APIs for Kibana wihtout the changes made for marking what system indices could be accessed using these APIs. In essence, this is a partial revert of elastic#53912. The changes for marking what system indices should be allowed access will be handled in a separate change. The APIs introduced here are wrapped versions of the existing REST endpoints. A new setting is also introduced since the Kibana system indices' names are allowed to be changed by a user in case multiple instances of Kibana use the same instance of Elasticsearch. Relates elastic#52385
jaymode
added a commit
that referenced
this pull request
Apr 8, 2020
This change reintroduces the system index APIs for Kibana without the changes made for marking what system indices could be accessed using these APIs. In essence, this is a partial revert of #53912. The changes for marking what system indices should be allowed access will be handled in a separate change. The APIs introduced here are wrapped versions of the existing REST endpoints. A new setting is also introduced since the Kibana system indices' names are allowed to be changed by a user in case multiple instances of Kibana use the same instance of Elasticsearch. Relates #52385
jaymode
added a commit
to jaymode/elasticsearch
that referenced
this pull request
Apr 8, 2020
This change reintroduces the system index APIs for Kibana without the changes made for marking what system indices could be accessed using these APIs. In essence, this is a partial revert of elastic#53912. The changes for marking what system indices should be allowed access will be handled in a separate change. The APIs introduced here are wrapped versions of the existing REST endpoints. A new setting is also introduced since the Kibana system indices' names are allowed to be changed by a user in case multiple instances of Kibana use the same instance of Elasticsearch. Relates elastic#52385
jaymode
added a commit
that referenced
this pull request
Apr 8, 2020
This change reintroduces the system index APIs for Kibana without the changes made for marking what system indices could be accessed using these APIs. In essence, this is a partial revert of #53912. The changes for marking what system indices should be allowed access will be handled in a separate change. The APIs introduced here are wrapped versions of the existing REST endpoints. A new setting is also introduced since the Kibana system indices' names are allowed to be changed by a user in case multiple instances of Kibana use the same instance of Elasticsearch. Relates #52385 Backport of #54858
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly reverts commit 4c0e8f1.
It should be re-added once #53909 is addressed.