-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Fix ClusterDisruptionIT.testAckedIndexing #53169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ClusterDisruptionIT.testAckedIndexing #53169
Conversation
Use assertBusy when doing reroute after bridged disruption, since it can return non-acked if a node is marked faulty by follower check after disruption ended. Closes elastic#53064
Pinging @elastic/es-distributed (:Distributed/CRUD) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Henning.
Thanks for reviewing, Nhat. |
Use assertBusy when doing reroute after bridged disruption, since it can return non-acked if a node is marked faulty by follower check after disruption ended. Closes #53064
Use assertBusy when doing reroute after bridged disruption, since it can return non-acked if a node is marked faulty by follower check after disruption ended. Closes #53064
This test has also failed in 6.8, see https://gradle-enterprise.elastic.co/s/t6xoiqr4ngnp4 Should we backport the fix there as well? |
@romseygeek , unfortunately that test failure is in a different place:
I find it reasonable to ignore this one incident since so much has happened in 7.x w.r.t. cluster healing (new coordination layer for instance) that it hardly makes sense to focus on this in 6.x. I would opt to leave the test unmuted in 6.x, unless this reoccurs too frequently (in case it fails in other interesting ways). |
Use assertBusy when doing reroute after bridged disruption,
since it can return non-acked if a node is marked faulty
by follower check after disruption ended.
Closes #53064