Make lucene snapshot repository exclusive to lucene packages #53353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When depending on lucene snapshots we point maven at our own s3 backed repository. However, in this case lucene packages should only be retrieved from this location, and no other packages should ever be found in that repo. This commit makes the maven repository exclusive to lucene packages.
rjernst
added
>enhancement
:Delivery/Build
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
|
@elasticmachine run elasticsearch-ci/2 |
|
@elasticmachine run elasticsearch-ci/2 |
mark-vieira
approved these changes
Mar 18, 2020
| repo.name = 'lucene-snapshots' | ||
| repo.url = "https://s3.amazonaws.com/download.elasticsearch.org/lucenesnapshots/${revision}" | ||
| } | ||
| repos.exclusiveContent { ExclusiveContentRepository exclusiveRepo -> | ||
| exclusiveRepo.filter { it.includeGroup('org.apache.lucene') } |
There was a problem hiding this comment.
Is this also specific only to snapshots? Do we ever use GA releases? And in that case, I assume we'd get those just from jcenter or maven central. If so, should we use a version regex filter here as well?
mark-vieira
approved these changes
Mar 18, 2020
| repo.name = 'lucene-snapshots' | ||
| repo.url = "https://s3.amazonaws.com/download.elasticsearch.org/lucenesnapshots/${revision}" | ||
| } | ||
| repos.exclusiveContent { ExclusiveContentRepository exclusiveRepo -> | ||
| exclusiveRepo.filter { | ||
| it.includeVersionByRegex('org\\.apache\\.lucene', '.*', ".*-snapshot-${revision}") |
There was a problem hiding this comment.
FYI, since this is Groovy we can use regex literal notation to avoid all the nasty string escaping so this could be /org\.apache\.lucene/ instead avoiding the redundant escape character.
rjernst
added a commit
that referenced
this pull request
Mar 19, 2020
When depending on lucene snapshots we point maven at our own s3 backed repository. However, in this case lucene packages should only be retrieved from this location, and no other packages should ever be found in that repo. This commit makes the maven repository exclusive to lucene packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When depending on lucene snapshots we point maven at our own s3 backed
repository. However, in this case lucene packages should only be
retrieved from this location, and no other packages should ever be found
in that repo. This commit makes the maven repository exclusive to lucene
packages.