Skip to content

Make lucene snapshot repository exclusive to lucene packages #53353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 19, 2020
Merged

Make lucene snapshot repository exclusive to lucene packages #53353

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0762fad
Make lucene snapshot repository exclusive to lucene packages
rjernst Mar 10, 2020
68ebb52
Merge branch 'master' into lucene_snapshot_filter
rjernst Mar 10, 2020
c77429c
sync with master
rjernst Mar 10, 2020
bcbcd72
add type
rjernst Mar 10, 2020
4a09aa8
Merge branch 'master' into lucene_snapshot_filter
rjernst Mar 18, 2020
4b7cbe5
use version filter too
rjernst Mar 18, 2020
14e8d5f
use groovy regex string
rjernst Mar 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion buildSrc/src/main/groovy/org/elasticsearch/gradle/BuildPlugin.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ import org.gradle.api.artifacts.Dependency
import org.gradle.api.artifacts.ModuleDependency
import org.gradle.api.artifacts.ProjectDependency
import org.gradle.api.artifacts.dsl.RepositoryHandler
import org.gradle.api.artifacts.repositories.ExclusiveContentRepository
import org.gradle.api.artifacts.repositories.IvyArtifactRepository
import org.gradle.api.artifacts.repositories.IvyPatternRepositoryLayout
import org.gradle.api.artifacts.repositories.MavenArtifactRepository
Expand Down Expand Up @@ -327,10 +328,16 @@ class BuildPlugin implements Plugin<Project> {
// extract the revision number from the version with a regex matcher
List<String> matches = (luceneVersion =~ /\w+-snapshot-([a-z0-9]+)/).getAt(0) as List<String>
String revision = matches.get(1)
repos.maven { MavenArtifactRepository repo ->
MavenArtifactRepository luceneRepo = repos.maven { MavenArtifactRepository repo ->
repo.name = 'lucene-snapshots'
repo.url = "https://s3.amazonaws.com/download.elasticsearch.org/lucenesnapshots/${revision}"
}
repos.exclusiveContent { ExclusiveContentRepository exclusiveRepo ->
exclusiveRepo.filter {
it.includeVersionByRegex('org\\.apache\\.lucene', '.*', ".*-snapshot-${revision}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, since this is Groovy we can use regex literal notation to avoid all the nasty string escaping so this could be /org\.apache\.lucene/ instead avoiding the redundant escape character.

}
exclusiveRepo.forRepositories(luceneRepo)
}
}
}

Expand Down