TermsLookup fields should be marked as Required in docs #53784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romseygeek
added
>docs
|
Pinging @elastic/es-docs (>docs) |
|
Pinging @elastic/es-search (:Search/Search) |
jrodewig
approved these changes
Mar 20, 2020
There was a problem hiding this comment.
LGTM.
Originally, I was saying "These parameters aren't required for the terms query."
However, this makes more sense as they're in a separate section and
we clearly explains terms lookup earlier.
Thanks @romseygeek!
romseygeek
added a commit
that referenced
this pull request
Mar 20, 2020
The terms-lookup section of our terms query docs currently state that the index, id and path fields are optional. They should be marked instead as required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The terms-lookup section of our terms query docs currently state that the
index,idandpathfields are optional. They should be marked insteadas required.