Skip to content

TermsLookup fields should be marked as Required in docs #53784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions docs/reference/query-dsl/terms-query.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ GET /_search
"query" : {
"terms" : {
"user" : ["kimchy", "elasticsearch"],
"boost" : 1.0
"boost" : 1.0
}
}
}
Expand Down Expand Up @@ -93,16 +93,16 @@ To perform a terms lookup, use the following parameters.
[[query-dsl-terms-lookup-params]]
====== Terms lookup parameters
`index`::
(Optional, string) Name of the index from which to fetch field values.
(Required, string) Name of the index from which to fetch field values.

`id`::
(Optional, string) <<mapping-id-field,ID>> of the document from which to fetch
(Required, string) <<mapping-id-field,ID>> of the document from which to fetch
field values.

`path`::
+
--
(Optional, string) Name of the field from which to fetch field values. {es} uses
(Required, string) Name of the field from which to fetch field values. {es} uses
these values as search terms for the query.

If the field values include an array of nested inner objects, you can access
Expand All @@ -117,7 +117,7 @@ when the document was indexed, this parameter is required.
[[query-dsl-terms-lookup-example]]
====== Terms lookup example

To see how terms lookup works, try the following example.
To see how terms lookup works, try the following example.

. Create an index with a `keyword` field named `color`.
+
Expand Down Expand Up @@ -244,4 +244,4 @@ field, {es} returns both documents.
}
----
// TESTRESPONSE[s/"took" : 17/"took" : $body.took/]
--
--