Clarify autoscaling feature flag registration #54427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit clarifies the autoscaling feature flag registration system property. The intention is that this feature flag is: - unset in snapshot builds - unset, true, or false in release builds - in release builds, unset behaves the same as false - therefore, we only register the enabled flag if the build is a snapshot build, or the build is a release build and the system property is set to true This commit clarifies that intention, and removed a confusion situation where the AUTOSCALING_FEATURE_FLAG_REGISTERED field would be set to false in a snapshot build, even though we were going to register the setting.
|
Pinging @elastic/es-distributed (:Distributed/Autoscaling) |
DaveCTurner
reviewed
Mar 30, 2020
| AUTOSCALING_FEATURE_FLAG_REGISTERED = false; | ||
| } else if (property == null) { | ||
| AUTOSCALING_FEATURE_FLAG_REGISTERED = null; |
There was a problem hiding this comment.
I suggest leaving it as a non-nullable boolean and saying this here.
Suggested change
| AUTOSCALING_FEATURE_FLAG_REGISTERED = null; | |
| AUTOSCALING_FEATURE_FLAG_REGISTERED = Build.CURRENT.isSnapshot(); |
Then this flag exactly reflects whether the feature flag is registered or not.
There was a problem hiding this comment.
There's two issues with that suggestion:
- my intention is that the field is aligned with the value of the system property
es.autoscaling_feature_flag_registered, it's merely aBooleanrepresentation of the value of that system property - the intention of using
Autoscaling#isSnapshotin determining whether or not to register the setting is so that it can be overridden in tests; if we tie whether or not to register the setting directly toBuild#Current#isSnapshotas you suggest, we lose that ability
| @@ -69,7 +71,7 @@ public Autoscaling(final Settings settings) { | |||
| */ | |||
| @Override | |||
| public List<Setting<?>> getSettings() { | |||
| if (isSnapshot() || AUTOSCALING_FEATURE_FLAG_REGISTERED) { | |||
| if (isSnapshot() || (AUTOSCALING_FEATURE_FLAG_REGISTERED != null && AUTOSCALING_FEATURE_FLAG_REGISTERED)) { | |||
There was a problem hiding this comment.
With my previous suggestion, this simplifies to the following:
Suggested change
| if (isSnapshot() || (AUTOSCALING_FEATURE_FLAG_REGISTERED != null && AUTOSCALING_FEATURE_FLAG_REGISTERED)) { | |
| if (AUTOSCALING_FEATURE_FLAG_REGISTERED) { |
DaveCTurner
approved these changes
Mar 30, 2020
|
@elasticmachine update branch |
jasontedor
added a commit
that referenced
this pull request
Mar 31, 2020
This commit clarifies the autoscaling feature flag registration system property. The intention is that this system property is: - unset in snapshot builds - unset, true, or false in release builds - in release builds, unset behaves the same as false - therefore, we only register the enabled flag if the build is a snapshot build, or the build is a release build and the system property is set to true This commit clarifies that intention, and removed a confusion situation where the AUTOSCALING_FEATURE_FLAG_REGISTERED field would be set to false in a snapshot build, even though we were going to register the setting.
jasontedor
deleted the
autoscaling-feature-flag-registration-clarification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit clarifies the autoscaling feature flag registration system property. The intention is that this system property is:
This commit clarifies that intention, and removed a confusion situation where the AUTOSCALING_FEATURE_FLAG_REGISTERED field would be set to false in a snapshot build, even though we were going to register the setting.
Relates #52088