Skip to content

Add checks for field collapse test failure #54831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mayya-sharipova
Copy link
Contributor

Add checks for field collapse test failure

There were some failures on 7.x of field collapse tests,
where total hits count was less than expected.
This adds an additional test to check total hits count
before field collapse queries to understand if the problem
is with field collapsing or with simply that writes have
not been completed yet.

Relates to #52416

@mayya-sharipova mayya-sharipova added the :Search/Search Search-related issues that do not fall into other categories label Apr 6, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@mayya-sharipova mayya-sharipova added >test-failure Triaged test failures from CI >test Issues or PRs that are addressing/adding tests labels Apr 6, 2020
There were some failures on 7.x of field collapse tests,
where total hits count was less then expected.
This adds an additional test to check total hits count
before field collapse queries to understand if the problem
is with field collapsing or with simply that writes have
not been finished yet

Relates to elastic#52416
@mayya-sharipova mayya-sharipova force-pushed the test-failure-field-collapse branch from 1a5084c to f62bc8c Compare April 6, 2020 18:20
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mayya-sharipova mayya-sharipova merged commit 0013dd4 into elastic:7.x Apr 6, 2020
@mayya-sharipova mayya-sharipova deleted the test-failure-field-collapse branch April 6, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search/Search Search-related issues that do not fall into other categories >test Issues or PRs that are addressing/adding tests >test-failure Triaged test failures from CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants