Skip to content

[CI] MixedClusterClientYamlTestSuiteIT test {p0=search/110_field_collapsing/field collapsing and inner_hits} #52416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
astefan opened this issue Feb 17, 2020 · 35 comments
Assignees
Labels
:Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team >test-failure Triaged test failures from CI

Comments

@astefan
Copy link
Contributor

astefan commented Feb 17, 2020

This one doesn't reproduce for me.

https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+7.x+multijob-windows-compatibility/os=windows-2019/442/console
https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+7.x+multijob-windows-compatibility/os=windows-2016/442/console
https://gradle-enterprise.elastic.co/s/7sb66cpgvp472
https://gradle-enterprise.elastic.co/s/ebbbgtn25jytw

java.lang.AssertionError: Failure at [search/110_field_collapsing:245]: hits.total didn't match expected value:
                    hits.total: expected Integer [6] but was Integer [5]

	at __randomizedtesting.SeedInfo.seed([65F24D0830A9A991:EDA672D29E55C469]:0)
	at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.executeSection(ESClientYamlSuiteTestCase.java:405)
	at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.test(ESClientYamlSuiteTestCase.java:382)
@astefan astefan added :Search/Search Search-related issues that do not fall into other categories >test-failure Triaged test failures from CI labels Feb 17, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@mayya-sharipova mayya-sharipova self-assigned this Feb 17, 2020
@mayya-sharipova
Copy link
Contributor

mayya-sharipova commented Feb 18, 2020

It looks like this test was run against 6.8 mixed cluster:
./gradlew ':qa:mixed-cluster:v6.8.7#mixedClusterTest' --tests "org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search/110_field_collapsing/field collapsing and inner_hits}" -Dtests.seed=BFA11AE1AA03B68A -Dtests.security.manager=true -Dtests.locale=ar-MA -Dtests.timezone=Australia/Sydney -Dcompiler.java=13

This doesn't reproduce for me.

It doesn't reproduce for me just on 7.x cluster either:
./gradlew ':distribution:archives:integ-test-zip:integTestRunner' --tests "org.elasticsearch.test.rest.IntegTestZipClientYamlTestSuiteIT.test {p0=search/110_field_collapsing/field collapsing and inner_hits}"

The stashed output from the failed test is:

  "stash" : {
    "body" : {
      "took" : 12,
      "timed_out" : false,
      "_shards" : {
        "total" : 5,
        "successful" : 5,
        "skipped" : 0,
        "failed" : 0
      },
      "hits" : {
        "total" : 5,
        "max_score" : null,
        "hits" : [
          {
            "_index" : "test",
            "_type" : "_doc",
            "_id" : "6",
            "_score" : null,
            "_source" : {
              "sort" : 36,
              "numeric_group" : 3
            },
            "fields" : {
              "numeric_group" : [
                3
              ]
            },
            "sort" : [
              36
            ],
            "inner_hits" : {
              "sub_hits" : {
                "hits" : {
                  "total" : 1,
                  "max_score" : null,
                  "hits" : [
                    {
                      "_index" : "test",
                      "_type" : "_doc",
                      "_id" : "6",
                      "_score" : null,
                      "_source" : {
                        "sort" : 36,
                        "numeric_group" : 3
                      },
                      "sort" : [
                        36
                      ]
                    }
                  ]
                }
              }
            }
          },
          {
            "_index" : "test",
            "_type" : "_doc",
            "_id" : "3",
            "_score" : null,
            "_source" : {
              "sort" : 24,
              "numeric_group" : 1
            },
            "fields" : {
              "numeric_group" : [
                1
              ]
            },
            "sort" : [
              24
            ],
            "inner_hits" : {
              "sub_hits" : {
                "hits" : {
                  "total" : 3,
                  "max_score" : null,
                  "hits" : [
                    {
                      "_index" : "test",
                      "_type" : "_doc",
                      "_id" : "2",
                      "_score" : null,
                      "_source" : {
                        "sort" : 6,
                        "numeric_group" : 1
                      },
                      "sort" : [
                        6
                      ]
                    },
                    {
                      "_index" : "test",
                      "_type" : "_doc",
                      "_id" : "1",
                      "_score" : "-Infinity",
                      "_source" : {
                        "sort" : 10,
                        "numeric_group" : 1
                      },
                      "sort" : [
                        10
                      ]
                    }
                  ]
                }
              }
            }
          },
          {
            "_index" : "test",
            "_type" : "_doc",
            "_id" : "4",
            "_score" : null,
            "_source" : {
              "sort" : 10,
              "numeric_group" : 25
            },
            "fields" : {
              "numeric_group" : [
                25
              ]
            },
            "sort" : [
              10
            ],
            "inner_hits" : {
              "sub_hits" : {
                "hits" : {
                  "total" : 2,
                  "max_score" : null,
                  "hits" : [
                    {
                      "_index" : "test",
                      "_type" : "_doc",
                      "_id" : "5",
                      "_score" : "-Infinity",
                      "_source" : {
                        "sort" : 5,
                        "numeric_group" : 25
                      },
                      "sort" : [
                        5
                      ]
                    },
                    {
                      "_index" : "test",
                      "_type" : "_doc",
                      "_id" : "4",
                      "_score" : null,
                      "_source" : {
                        "sort" : 10,
                        "numeric_group" : 25
                      },
                      "sort" : [
                        10
                      ]
                    }
                  ]
                }
              }
            }
          }
        ]
      }
    }
  }
}]

As expected, 3 collapsed groups returned with hits.total: 1, 3 and 2 which should sum up to 6, but incorrectly summed up to 5.
I wonder if the failure is related to one of the hits having "_score" : "-Infinity"

@mayya-sharipova
Copy link
Contributor

mayya-sharipova commented Mar 27, 2020

There were no failures of this test after Feb 17.

There is another failure of this test from Jan 27 but on different condition:
https://gradle-enterprise.elastic.co/s/j3kbaua2fjy6s

java.lang.AssertionError: hits.hits.1.inner_hits.sub_hits.hits.total didn't match expected value: |
hits.hits.1.inner_hits.sub_hits.hits.total: expected Integer [3] but was Integer [2]

Here in the missing hit in the second group for inner hits, a doc with "_id" : "2", "sort" : 6 .

[{
  "stash" : {
    "body" : {
      "took" : 32,
      "timed_out" : false,
      "_shards" : {
        "total" : 5,
        "successful" : 5,
        "skipped" : 0,
        "failed" : 0
      },
      "hits" : {
        "total" : 6,
        "max_score" : null,
        "hits" : [
          {
            "_index" : "test",
            "_type" : "_doc",
            "_id" : "6",
            "_score" : "-Infinity",
            "_source" : {
              "sort" : 36,
              "numeric_group" : 3
            },
            "fields" : {
              "numeric_group" : [
                3
              ]
            },
            "sort" : [
              36
            ],
            "inner_hits" : {
              "sub_hits" : {
                "hits" : {
                  "total" : 1,
                  "max_score" : null,
                  "hits" : [
                    {
                      "_index" : "test",
                      "_type" : "_doc",
                      "_id" : "6",
                      "_score" : "-Infinity",
                      "_source" : {
                        "sort" : 36,
                        "numeric_group" : 3
                      },
                      "sort" : [
                        36
                      ]
                    }
                  ]
                }
              }
            }
          },
          {
            "_index" : "test",
            "_type" : "_doc",
            "_id" : "3",
            "_score" : null,
            "_source" : {
              "sort" : 24,
              "numeric_group" : 1
            },
            "fields" : {
              "numeric_group" : [
                1
              ]
            },
            "sort" : [
              24
            ],
            "inner_hits" : {
              "sub_hits" : {
                "hits" : {
                  "total" : 2,
                  "max_score" : null,
                  "hits" : [
                    {
                      "_index" : "test",
                      "_type" : "_doc",
                      "_id" : "2",
                      "_score" : "-Infinity",
                      "_source" : {
                        "sort" : 6,
                        "numeric_group" : 1
                      },
                      "sort" : [
                        6
                      ]
                    },
                    {
                      "_index" : "test",
                      "_type" : "_doc",
                      "_id" : "3",
                      "_score" : null,
                      "_source" : {
                        "sort" : 24,
                        "numeric_group" : 1
                      },
                      "sort" : [
                        24
                      ]
                    }
                  ]
                }
              }
            }
          },
          {
            "_index" : "test",
            "_type" : "_doc",
            "_id" : "4",
            "_score" : "-Infinity",
            "_source" : {
              "sort" : 10,
              "numeric_group" : 25
            },
            "fields" : {
              "numeric_group" : [
                25
              ]
            },
            "sort" : [
              10
            ],
            "inner_hits" : {
              "sub_hits" : {
                "hits" : {
                  "total" : 2,
                  "max_score" : null,
                  "hits" : [
                    {
                      "_index" : "test",
                      "_type" : "_doc",
                      "_id" : "5",
                      "_score" : null,
                      "_source" : {
                        "sort" : 5,
                        "numeric_group" : 25
                      },
                      "sort" : [
                        5
                      ]
                    },
                    {
                      "_index" : "test",
                      "_type" : "_doc",
                      "_id" : "4",
                      "_score" : "-Infinity",
                      "_source" : {
                        "sort" : 10,
                        "numeric_group" : 25
                      },
                      "sort" : [
                        10
                      ]
                    }
                  ]
                }
              }
            }
          }
        ]
      }
    }
  }
}]

@mayya-sharipova
Copy link
Contributor

Another failure from Nov 1, 2019
https://gradle-enterprise.elastic.co/s/uztw7loist4la

Here there is also a missing document in the second group 1 for inner hits, a doc with "_id" : "3", "sort" : 24.

[{
  "stash" : {
    "body" : {
      "took" : 18,
      "timed_out" : false,
      "_shards" : {
        "total" : 2,
        "successful" : 2,
        "skipped" : 0,
        "failed" : 0
      },
      "hits" : {
        "total" : 5,
        "max_score" : null,
        "hits" : [
          {
            "_index" : "test",
            "_type" : "_doc",
            "_id" : "6",
            "_score" : null,
            "_source" : {
              "sort" : 36,
              "numeric_group" : 3
            },
            "fields" : {
              "numeric_group" : [
                3
              ]
            },
            "sort" : [
              36
            ],
            "inner_hits" : {
              "sub_hits" : {
                "hits" : {
                  "total" : 1,
                  "max_score" : null,
                  "hits" : [
                    {
                      "_index" : "test",
                      "_type" : "_doc",
                      "_id" : "6",
                      "_score" : null,
                      "_source" : {
                        "sort" : 36,
                        "numeric_group" : 3
                      },
                      "sort" : [
                        36
                      ]
                    }
                  ]
                }
              }
            }
          },
          {
            "_index" : "test",
            "_type" : "_doc",
            "_id" : "1",
            "_score" : null,
            "_source" : {
              "sort" : 10,
              "numeric_group" : 1
            },
            "fields" : {
              "numeric_group" : [
                1
              ]
            },
            "sort" : [
              10
            ],
            "inner_hits" : {
              "sub_hits" : {
                "hits" : {
                  "total" : 3,
                  "max_score" : null,
                  "hits" : [
                    {
                      "_index" : "test",
                      "_type" : "_doc",
                      "_id" : "2",
                      "_score" : null,
                      "_source" : {
                        "sort" : 6,
                        "numeric_group" : 1
                      },
                      "sort" : [
                        6
                      ]
                    },
                    {
                      "_index" : "test",
                      "_type" : "_doc",
                      "_id" : "1",
                      "_score" : null,
                      "_source" : {
                        "sort" : 10,
                        "numeric_group" : 1
                      },
                      "sort" : [
                        10
                      ]
                    }
                  ]
                }
              }
            }
          },
          {
            "_index" : "test",
            "_type" : "_doc",
            "_id" : "4",
            "_score" : null,
            "_source" : {
              "sort" : 10,
              "numeric_group" : 25
            },
            "fields" : {
              "numeric_group" : [
                25
              ]
            },
            "sort" : [
              10
            ],
            "inner_hits" : {
              "sub_hits" : {
                "hits" : {
                  "total" : 2,
                  "max_score" : null,
                  "hits" : [
                    {
                      "_index" : "test",
                      "_type" : "_doc",
                      "_id" : "5",
                      "_score" : null,
                      "_source" : {
                        "sort" : 5,
                        "numeric_group" : 25
                      },
                      "sort" : [
                        5
                      ]
                    },
                    {
                      "_index" : "test",
                      "_type" : "_doc",
                      "_id" : "4",
                      "_score" : null,
                      "_source" : {
                        "sort" : 10,
                        "numeric_group" : 25
                      },
                      "sort" : [
                        10
                      ]
                    }
                  ]
                }
              }
            }
          }
        ]
      }
    }
  }
}]

@mayya-sharipova
Copy link
Contributor

it looks like some docs were missed during collection in some cases during the initial query phase, or in other cases during inner_hits phase.

I am out of ideas how this could happen.

@mayya-sharipova
Copy link
Contributor

mayya-sharipova commented Apr 6, 2020

Another failure on Apr 3 on 7.x windows.
The test failures are mostly on Windows.

gradlew ':qa:mixed-cluster:v6.8.9#mixedClusterTest' --tests "org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search/110_field_collapsing/field collapsing}" \
  -Dtests.seed=142BCCC577B41C12 \
  -Dtests.security.manager=true \
  -Dtests.locale=th-TH \
  -Dtests.timezone=Pacific/Enderbury \
  -Dcompiler.java=13

Build scan: https://gradle-enterprise.elastic.co/s/zh4vk2ddkfdc2

java.lang.AssertionError: Failure at [search/110_field_collapsing:67]: hits.total didn't match expected value:
hits.total: expected Integer [6] but was Integer [3]

[{
  1>   "stash" : {
  1>     "body" : {
  1>       "took" : 18,
  1>       "timed_out" : false,
  1>       "_shards" : {
  1>         "total" : 5,
  1>         "successful" : 5,
  1>         "skipped" : 0,
  1>         "failed" : 0
  1>       },
  1>       "hits" : {
  1>         "total" : 3,
  1>         "max_score" : null,
  1>         "hits" : [
  1>           {
  1>             "_index" : "test",
  1>             "_type" : "_doc",
  1>             "_id" : "3",
  1>             "_score" : null,
  1>             "_source" : {
  1>               "sort" : 24,
  1>               "numeric_group" : 1
  1>             },
  1>             "fields" : {
  1>               "numeric_group" : [
  1>                 1
  1>               ]
  1>             },
  1>             "sort" : [
  1>               24
  1>             ]
  1>           },
  1>           {
  1>             "_index" : "test",
  1>             "_type" : "_doc",
  1>             "_id" : "5",
  1>             "_score" : "-Infinity",
  1>             "_source" : {
  1>               "sort" : 5,
  1>               "numeric_group" : 25
  1>             },
  1>             "fields" : {
  1>               "numeric_group" : [
  1>                 25
  1>               ]
  1>             },
  1>             "sort" : [
  1>               5
  1>             ]
  1>           }
  1>         ]
  1>       }
  1>     }
  1>   }
  1> }]

mayya-sharipova added a commit to mayya-sharipova/elasticsearch that referenced this issue Apr 6, 2020
There were some failures on 7.x of field collapse tests,
where total hits count was less then expected.
This adds an additional test to check total hits count
before field collapse queries to understand if the problem
is with field collapsing or with simply that writes have
not been finished yet

Relates to elastic#52416
mayya-sharipova added a commit that referenced this issue Apr 6, 2020
There were some failures on 7.x of field collapse tests,
where total hits count was less then expected.
This adds an additional test to check total hits count
before field collapse queries to understand if the problem
is with field collapsing or with simply that writes have
not been finished yet

Relates to #52416
@rjernst rjernst added the Team:Search Meta label for search team label May 4, 2020
@jtibshirani
Copy link
Contributor

Another instance of this failure just popped up: https://gradle-enterprise.elastic.co/s/xfqfl3g3q6th2

@benwtrent
Copy link
Member

Yet another failure: https://gradle-enterprise.elastic.co/s/4tzbht3q5hqtm

org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT > test {p0=search/110_field_collapsing/field collapsing and inner_hits} FAILED
    java.lang.AssertionError: Failure at [search/110_field_collapsing:120]: hits.total didn't match expected value:
                        hits.total: expected Integer [6] but was Integer [5]
        at __randomizedtesting.SeedInfo.seed([AA293831BC657667:227D07EB12991B9F]:0)
        at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.executeSection(ESClientYamlSuiteTestCase.java:405)
        at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.test(ESClientYamlSuiteTestCase.java:382)
        at sun.reflect.GeneratedMethodAccessor19.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1750)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:938)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:974)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:988)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:49)
        at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45)
        at org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:48)
        at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:64)
        at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:47)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
        at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:817)
        at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:468)
        at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:947)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:832)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:883)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:894)
        at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:41)
        at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
        at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
        at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:47)
        at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:64)
        at org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:54)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
        at java.lang.Thread.run(Thread.java:748)

        Caused by:
        java.lang.AssertionError: hits.total didn't match expected value:
                            hits.total: expected Integer [6] but was Integer [5]
            at org.elasticsearch.test.rest.yaml.section.MatchAssertion.doAssert(MatchAssertion.java:93)
            at org.elasticsearch.test.rest.yaml.section.Assertion.execute(Assertion.java:76)
            at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.executeSection(ESClientYamlSuiteTestCase.java:398)

stack dump:

2> WARNING: request [PUT http://[::1]:59596/test?include_type_name=false&error_trace=true] returned 2 warnings: [299 Elasticsearch-6.8.9-SNAPSHOT-f2369f6 "the default number of shards will change from [5] to [1] in 7.0.0; if you wish to continue using the default of [5] shards, you must manage this on the create index request or with an index template"],[299 Elasticsearch-7.7.0-SNAPSHOT-2daf9bf3729580b70ee04a8ced6b06fd06e951ae "[types removal] Using include_type_name in create index requests is deprecated. The parameter will be removed in the next major version."]
  1> [2020-05-11T09:24:04,919][INFO ][o.e.b.MixedClusterClientYamlTestSuiteIT] [test] Stash dump on test failure [{
  1>   "stash" : {
  1>     "body" : {
  1>       "took" : 24,
  1>       "timed_out" : false,
  1>       "_shards" : {
  1>         "total" : 5,
  1>         "successful" : 5,
  1>         "skipped" : 0,
  1>         "failed" : 0
  1>       },
  1>       "hits" : {
  1>         "total" : 5,
  1>         "max_score" : null,
  1>         "hits" : [
  1>           {
  1>             "_index" : "test",
  1>             "_type" : "_doc",
  1>             "_id" : "6",
  1>             "_score" : "-Infinity",
  1>             "_source" : {
  1>               "sort" : 36,
  1>               "numeric_group" : 3
  1>             },
  1>             "fields" : {
  1>               "numeric_group" : [
  1>                 3
  1>               ]
  1>             },
  1>             "sort" : [
  1>               36
  1>             ],
  1>             "inner_hits" : {
  1>               "sub_hits" : {
  1>                 "hits" : {
  1>                   "total" : 1,
  1>                   "max_score" : null,
  1>                   "hits" : [
  1>                     {
  1>                       "_index" : "test",
  1>                       "_type" : "_doc",
  1>                       "_id" : "6",
  1>                       "_score" : "-Infinity",
  1>                       "_source" : {
  1>                         "sort" : 36,
  1>                         "numeric_group" : 3
  1>                       },
  1>                       "sort" : [
  1>                         36
  1>                       ]
  1>                     }
  1>                   ]
  1>                 }
  1>               }
  1>             }
  1>           },
  1>           {
  1>             "_index" : "test",
  1>             "_type" : "_doc",
  1>             "_id" : "3",
  1>             "_score" : null,
  1>             "_source" : {
  1>               "sort" : 24,
  1>               "numeric_group" : 1
  1>             },
  1>             "fields" : {
  1>               "numeric_group" : [
  1>                 1
  1>               ]
  1>             },
  1>             "sort" : [
  1>               24
  1>             ],
  1>             "inner_hits" : {
  1>               "sub_hits" : {
  1>                 "hits" : {
  1>                   "total" : 3,
  1>                   "max_score" : null,
  1>                   "hits" : [
  1>                     {
  1>                       "_index" : "test",
  1>                       "_type" : "_doc",
  1>                       "_id" : "2",
  1>                       "_score" : "-Infinity",
  1>                       "_source" : {
  1>                         "sort" : 6,
  1>                         "numeric_group" : 1
  1>                       },
  1>                       "sort" : [
  1>                         6
  1>                       ]
  1>                     },
  1>                     {
  1>                       "_index" : "test",
  1>                       "_type" : "_doc",
  1>                       "_id" : "1",
  1>                       "_score" : "-Infinity",
  1>                       "_source" : {
  1>                         "sort" : 10,
  1>                         "numeric_group" : 1
  1>                       },
  1>                       "sort" : [
  1>                         10
  1>                       ]
  1>                     }
  1>                   ]
  1>                 }
  1>               }
  1>             }
  1>           },
  1>           {
  1>             "_index" : "test",
  1>             "_type" : "_doc",
  1>             "_id" : "4",
  1>             "_score" : "-Infinity",
  1>             "_source" : {
  1>               "sort" : 10,
  1>               "numeric_group" : 25
  1>             },
  1>             "fields" : {
  1>               "numeric_group" : [
  1>                 25
  1>               ]
  1>             },
  1>             "sort" : [
  1>               10
  1>             ],
  1>             "inner_hits" : {
  1>               "sub_hits" : {
  1>                 "hits" : {
  1>                   "total" : 2,
  1>                   "max_score" : null,
  1>                   "hits" : [
  1>                     {
  1>                       "_index" : "test",
  1>                       "_type" : "_doc",
  1>                       "_id" : "5",
  1>                       "_score" : null,
  1>                       "_source" : {
  1>                         "sort" : 5,
  1>                         "numeric_group" : 25
  1>                       },
  1>                       "sort" : [
  1>                         5
  1>                       ]
  1>                     },
  1>                     {
  1>                       "_index" : "test",
  1>                       "_type" : "_doc",
  1>                       "_id" : "4",
  1>                       "_score" : "-Infinity",
  1>                       "_source" : {
  1>                         "sort" : 10,
  1>                         "numeric_group" : 25
  1>                       },
  1>                       "sort" : [
  1>                         10
  1>                       ]
  1>                     }
  1>                   ]
  1>                 }
  1>               }
  1>             }
  1>           }
  1>         ]
  1>       }
  1>     }
  1>   }
  1> }]

@iverase
Copy link
Contributor

iverase commented Jun 23, 2020

Another failure: https://gradle-enterprise.elastic.co/s/3no2o4uqgdf7q

same error:

15:52:54   2> java.lang.AssertionError: Failure at [search/110_field_collapsing:110]: hits.total didn't match expected value:
15:52:54                         hits.total: expected Integer [6] but was Integer [5]
15:52:54         at __randomizedtesting.SeedInfo.seed([5CDC11C06B261E6A:D4882E1AC5DA7392]:0)
15:52:54         at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.executeSection(ESClientYamlSuiteTestCase.java:405)

@andreidan
Copy link
Contributor

Another failure https://gradle-enterprise.elastic.co/s/sll6vajxn24qa

Caused by: java.lang.AssertionError: count didn't match expected value:
                         count: expected Integer [6] but was Integer [5]

	at org.elasticsearch.test.rest.yaml.section.MatchAssertion.doAssert(MatchAssertion.java:93)
	at org.elasticsearch.test.rest.yaml.section.Assertion.execute(Assertion.java:76)
	at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.executeSection(ESClientYamlSuiteTestCase.java:407)```

@jaymode
Copy link
Member

jaymode commented Aug 12, 2020

Another failure https://gradle-enterprise.elastic.co/s/tn64v7lwgntzm

    java.lang.AssertionError: Failure at [search/110_field_collapsing:296]: count didn't match expected value:
                             count: expected Integer [6] but was Integer [3]

@droberts195
Copy link
Contributor

Another failure in https://gradle-enterprise.elastic.co/s/qls5tmomhsvpi

java.lang.AssertionError: Failure at [search/110_field_collapsing:205]: count didn't match expected value: 
   count: expected Integer [6] but was Integer [5]

@jtibshirani
Copy link
Contributor

A similar failure, but for 110_field_collapsing/field collapsing and from: https://gradle-enterprise.elastic.co/s/7we7kypqlxqhg

@cbuescher
Copy link
Member

This looks also related but is in ' 110_field_collapsing/no hits and inner_hits': https://gradle-enterprise.elastic.co/s/yv4kj4xx7bqj2
7.9 branch and 'v6.8.13#mixedClusterTest'

@pgomulka
Copy link
Contributor

@hendrikmuhs
Copy link

@danielmitterdorfer
Copy link
Member

Another failure on 7.10: https://gradle-enterprise.elastic.co/s/h5mb2lkr3witq:

java.lang.AssertionError: Failure at [search/110_field_collapsing:294]: count didn't match expected value:
                         count: expected Integer [6] but was Integer [5]

reproduction line (does not reproduce locally):

./gradlew ':qa:mixed-cluster:v6.8.14#mixedClusterTest' --tests "org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search/110_field_collapsing/field collapsing and inner_hits}" \
  -Dtests.seed=8232D64881B1D868 \
  -Dtests.security.manager=true \
  -Dtests.locale=de \
  -Dtests.timezone=Africa/Malabo \
  -Druntime.java=8

There is also a related test failing with the reproduction line (does not reproduce locally):

./gradlew ':qa:mixed-cluster:v6.8.14#mixedClusterTest' --tests "org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search/110_field_collapsing/no hits and inner_hits}" \
  -Dtests.seed=8232D64881B1D868 \
  -Dtests.security.manager=true \
  -Dtests.locale=de \
  -Dtests.timezone=Africa/Malabo \
  -Druntime.java=8

I'll mute these tests now on master, 7.x and 7.10.

@ywangd
Copy link
Member

ywangd commented Dec 2, 2020

Another one: https://gradle-enterprise.elastic.co/s/plgo6plomydn2

java.lang.AssertionError: Failure at [search/110_field_collapsing:339]: count didn't match expected value: |  
-- | --
  | count: expected Integer [6] but was Integer [3]

The exact line (339) where it failed is different from the above failures. But they are from the same test suite.

@dimitris-athanasiou
Copy link
Contributor

Another failure: https://gradle-enterprise.elastic.co/s/t66afxe5e3nr4

Failure at [search/110_field_collapsing:63]: count didn't match expected value: |  
-- | --
  | count: expected Integer [6] but was Integer [5]

@costin
Copy link
Member

costin commented Dec 22, 2020

Might be related to #66728

@benwtrent
Copy link
Member

Exact same failure. Still a mixed cluster test against 6.8 and 7.x.

https://gradle-enterprise.elastic.co/s/nboqmld334tyq

org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT > test {p0=search/110_field_collapsing/field collapsing, inner_hits and maxConcurrentGroupRequests} FAILED |  
-- | --
  | java.lang.AssertionError: Failure at [search/110_field_collapsing:209]: count didn't match expected value: |  
  | count: expected Integer [6] but was Integer [5] |  
  | at __randomizedtesting.SeedInfo.seed([C52EDEAE6FEC69EF:4D7AE174C1100417]:0) |  
  | at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.executeSection(ESClientYamlSuiteTestCase.java:416) |  
  | at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.test(ESClientYamlSuiteTestCase.java:393) |  
  | at sun.reflect.GeneratedMethodAccessor16.invoke(Unknown Source) |  
  | at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) |  
  | at java.lang.reflect.Method.invoke(Method.java:498) |  
  | at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1750) |  
  | at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:938) |  
  | at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:974) |  
  | at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:988) |  
  | at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) |  
  | at org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:49) |  
  | at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45) |  
  | at org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:48) |  
  | at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:64) |  
  | at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:47) |  
  | at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) |  
  | at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368) |  
  | at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:817) |  
  | at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:468) |  
  | at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:947) |  
  | at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:832) |  
  | at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:883) |  
  | at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:894) |  
  | at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45) |  
  | at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) |  
  | at org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:41) |  
  | at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40) |  
  | at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40) |  
  | at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) |  
  | at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) |  
  | at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) |  
  | at org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53) |  
  | at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:47) |  
  | at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:64) |  
  | at org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:54) |  
  | at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) |  
  | at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368) |  
  | at java.lang.Thread.run(Thread.java:748) |  
  |   |  
  | Caused by: |  
  | java.lang.AssertionError: count didn't match expected value: |  
  | count: expected Integer [6] but was Integer [5] |  
  | at org.elasticsearch.test.rest.yaml.section.MatchAssertion.doAssert(MatchAssertion.java:93) |  
  | at org.elasticsearch.test.rest.yaml.section.Assertion.execute(Assertion.java:76) |  
  | at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.executeSection(ESClientYamlSuiteTestCase.java:409) |  
  | ... 37 more

@hendrikmuhs
Copy link

@martijnvg
Copy link
Member

martijnvg commented Jan 19, 2021

Two other instances that happened today on 7.11 and 7.x branches:

@cbuescher
Copy link
Member

DaveCTurner added a commit to javanna/elasticsearch that referenced this issue Jan 31, 2021
@astefan
Copy link
Contributor Author

astefan commented Feb 11, 2021

@henningandersen
Copy link
Contributor

Another related failure in MixedClusterClientYamlTestSuiteIT.test {p0=search/110_field_collapsing/field collapsing and from}:

Failure at [search/110_field_collapsing:100]: count didn't match expected value:	
                         count: expected Integer [6] but was Integer [5]

7.11: https://gradle-enterprise.elastic.co/s/4dv4mhb4skwna
7.12: https://gradle-enterprise.elastic.co/s/adfluupxagigg

Muted in #69587

@benwtrent
Copy link
Member

https://gradle-enterprise.elastic.co/s/mazkqci6eugzc

Happened again but this time in a different test:

org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT > test {p0=search/110_field_collapsing/field collapsing, inner_hits and version} FAILED
    java.lang.AssertionError: Failure at [search/110_field_collapsing:401]: count didn't match expected value:
                             count: expected Integer [6] but was Integer [5]
        at __randomizedtesting.SeedInfo.seed([EC78DC9D8C1D4218:642CE34722E12FE0]:0)
        at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.executeSection(ESClientYamlSuiteTestCase.java:450)
        at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.test(ESClientYamlSuiteTestCase.java:427)
        at sun.reflect.GeneratedMethodAccessor16.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1750)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:938)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:974)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:988)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:49)
        at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45)
        at org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:48)
        at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:64)
        at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:47)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
        at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:817)
        at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:468)
        at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:947)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:832)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:883)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:894)
        at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:41)
        at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
        at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
        at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:47)
        at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:64)
        at org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:54)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
        at java.lang.Thread.run(Thread.java:748)

        Caused by:
        java.lang.AssertionError: count didn't match expected value:
                                 count: expected Integer [6] but was Integer [5]
            at org.elasticsearch.test.rest.yaml.section.MatchAssertion.doAssert(MatchAssertion.java:82)
            at org.elasticsearch.test.rest.yaml.section.Assertion.execute(Assertion.java:65)
            at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.executeSection(ESClientYamlSuiteTestCase.java:443)
            ... 37 more

mayya-sharipova added a commit to mayya-sharipova/elasticsearch that referenced this issue Mar 1, 2021
Break up field collapsting tests into 2:
1) simple indexing and 2) indexingwith versions
to check if a problem of documents missing could be because of versions.

Relates to elastic#52416
mayya-sharipova added a commit that referenced this issue Mar 8, 2021
Break up field collapsting tests into 2:
1) simple indexing and 2) indexingwith versions
to check if a problem of documents missing could be because of versions.

Relates to #52416
@valeriy42
Copy link
Contributor

Another related failure here https://gradle-enterprise.elastic.co/s/shre4iovbbwly

@mayya-sharipova
Copy link
Contributor

Another related failure here https://gradle-enterprise.elastic.co/s/shre4iovbbwly

The test that failed was 110_field_collapsing/field collapsing, inner_hits and version, which was removed in #69753 as an unnecessary test.

@nik9000
Copy link
Member

nik9000 commented Mar 17, 2021

Got another one!

@mayya-sharipova
Copy link
Contributor

I will mute the test today.

@dnhatn dnhatn assigned dnhatn and unassigned mayya-sharipova Mar 17, 2021
dnhatn added a commit that referenced this issue Mar 17, 2021
@dnhatn
Copy link
Member

dnhatn commented Mar 17, 2021

I think shard relocations are causing these failures. I've disabled relocations in this test in 0675b14. I will dig into it deeper later.

@dnhatn
Copy link
Member

dnhatn commented Jul 7, 2021

I've removed AwaitsFix for this test. Please open a new issue if this test fails again.

@dnhatn dnhatn closed this as completed Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team >test-failure Triaged test failures from CI
Projects
None yet
Development

No branches or pull requests