Skip to content

[Docs]Adds ip_range datatype to core datatypes range list #55446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2020
Merged

[Docs]Adds ip_range datatype to core datatypes range list #55446

merged 1 commit into from
Apr 20, 2020

Conversation

benskelker
Copy link
Contributor

@benskelker benskelker commented Apr 20, 2020 •
edited
Loading

Adds the ip_range datatype to the Core datatypes range list.

@FrankHassanabad noticed it was missing.

Preview

@benskelker benskelker added >docs General docs changes v7.7.0 labels Apr 20, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@benskelker
Copy link
Contributor Author

@jrodewig @debadair if other reviewers are needed, can you add them?

Thanks,

jrodewig
jrodewig approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @benskelker.

I'll merge and backport this.

@jrodewig jrodewig added :Search Foundations/Mapping Index mappings, including merging and defining field types v6.8.9 v7.6.3 v7.8.0 v8.0.0 labels Apr 20, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Mapping)

@jrodewig jrodewig merged commit a085183 into elastic:master Apr 20, 2020
jrodewig pushed a commit that referenced this pull request Apr 20, 2020
@benskelker @jrodewig
[DOCS] Add ip_range datatype to core datatypes range list (#55446)
74f55ec
jrodewig pushed a commit that referenced this pull request Apr 20, 2020
@benskelker @jrodewig
[DOCS] Add ip_range datatype to core datatypes range list (#55446)
57ec134
jrodewig pushed a commit that referenced this pull request Apr 20, 2020
@benskelker @jrodewig
[DOCS] Add ip_range datatype to core datatypes range list (#55446)
03712c6
jrodewig pushed a commit that referenced this pull request Apr 20, 2020
@benskelker @jrodewig
[DOCS] Add ip_range datatype to core datatypes range list (#55446)
4068a3d
@jrodewig
Copy link
Contributor

Backport commits

master a085183
7.x 74f55ec
7.7 57ec134
7.6 03712c6
6.8 4068a3d

@benskelker
Copy link
Contributor Author

Thanks @jrodewig

@benskelker benskelker deleted the adds_ip_range_datatype branch April 20, 2020 13:15
FrankHassanabad
FrankHassanabad reviewed Apr 20, 2020
View reviewed changes
Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankHassanabad FrankHassanabad FrankHassanabad left review comments

@jrodewig jrodewig jrodewig approved these changes

@debadair debadair Awaiting requested review from debadair

Assignees
No one assigned
Labels
>docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types v6.8.9 v7.6.3 v7.7.0 v7.8.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@benskelker @elasticmachine @jrodewig @FrankHassanabad @jakelandis