Ensure fetch fields aren't dropped when rewriting search. #61383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we didn't retain the requested fields when performing a shallow copy of the search source. This meant that when a search was rewritten, we could drop the requested fields and fail to return them in the response.
jtibshirani
added
>non-issue
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
|
I've marked this as 'non-issue' because it wasn't released. For context, @astefan discovered this bug through the SQL test suites. |
jimczi
approved these changes
Aug 20, 2020
| public void testShallowCopy() { | ||
| SearchSourceBuilder original = createSearchSourceBuilder(); | ||
| SearchSourceBuilder copy = original.shallowCopy(); | ||
| assertEquals(original, copy); |
There was a problem hiding this comment.
++, maybe run few iterations to catch more cases ?
|
@elasticmachine run elasticsearch-ci/packaging-sample-windows |
|
Thanks @jimczi for the review. |
jtibshirani
added a commit
to jtibshirani/elasticsearch
that referenced
this pull request
Aug 20, 2020
jtibshirani
added a commit
that referenced
this pull request
Aug 20, 2020
The skip can be removed now that #61383 is backported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we didn't retain the requested fields when performing a shallow copy
of the search source. This meant that when a search was rewritten, we could drop
the requested fields and fail to return them in the response.