Skip to content

Ensure fetch fields aren't dropped when rewriting search. #61390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 20, 2020
Merged

Ensure fetch fields aren't dropped when rewriting search. #61390

merged 2 commits into from
Aug 20, 2020

Conversation

jtibshirani
Copy link
Contributor

Backport of #61383.

@jtibshirani
Ensure fetch fields aren't dropped when rewriting search. (elastic#61383
6bd3b12 
)

Previously we didn't retain the requested fields when performing a shallow copy
of the search source. This meant that when a search was rewritten, we could drop
the requested fields and fail to return them in the response.
@jtibshirani
Remove skip in REST yml test.
3e2d55e
@jtibshirani jtibshirani added >non-issue :Search/Search Search-related issues that do not fall into other categories backport labels Aug 20, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Aug 20, 2020
@jtibshirani jtibshirani merged commit 85ad328 into elastic:7.x Aug 20, 2020
@jtibshirani jtibshirani deleted the fields-search-rewrite branch August 20, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport >non-issue :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtibshirani @elasticmachine