Break up field collapsing tests #69753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Break up field collapsting tests into 2: 1) simple indexing and 2) indexingwith versions to check if a problem of documents missing could be because of versions. Relates to elastic#52416
mayya-sharipova
force-pushed
the
field-collapsing
branch
from
7f19dc7 to
228b4a2
Compare
mayya-sharipova
added
the
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
|
I had a discussion with @ywelsch about this test failure. We initially hypothesize that typeless indexing API could have some problems when using for 6.8 nodes. But after talking to @jtibshirani about this, she pointed out that this should not be a problem, as in our test framework in So this PR introduces another hypothesis that a problem with missing documents could be related to |
jtibshirani
approved these changes
Mar 2, 2021
pgomulka
added a commit
that referenced
this pull request
Mar 8, 2021
'search/110_field_collapsing/field collapsing and inner_hits', is enabled in 7.x (#69753 )and the compatible api is not implemented yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Break up field collapsting tests into 2:
to check if a problem of documents missing could be because of versions.
Relates to #52416