Preserve half_float's precision in fields API #70653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik9000
added
>enhancement
:Search Foundations/Mapping
|
Pinging @elastic/es-search (Team:Search) |
This modifies the fields API to return values with half_float's precision. This makes the fields API better reflect what we've indexed which we'd like to to do in general. It does make the values that come back "uglier" because things like `3.14` end up becoming `3.140625`. But that is what is actually in the index so itsmore "real". Closes elastic#70260
|
@elasticmachine update branch |
jpountz
approved these changes
Mar 25, 2021
|
Thanks for the reviews folks! |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Mar 25, 2021
This modifies the fields API to return values with half_float's precision. This makes the fields API better reflect what we've indexed which we'd like to to do in general. It does make the values that come back "uglier" because things like `3.14` end up becoming `3.140625`. But that is what is actually in the index so itsmore "real". Closes elastic#70260
nik9000
added a commit
that referenced
this pull request
Mar 25, 2021
I made a mistake in a randomized test in #70653. It didn't trigger on my PRs but the intake caught it. I just misplaced a decimal place.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Mar 25, 2021
I made a mistake in a randomized test in elastic#70653. It didn't trigger on my PRs but the intake caught it. I just misplaced a decimal place.
nik9000
added a commit
that referenced
this pull request
Mar 25, 2021
…70888) This modifies the fields API to return values with half_float's precision. This makes the fields API better reflect what we've indexed which we'd like to to do in general. It does make the values that come back "uglier" because things like `3.14` end up becoming `3.140625`. But that is what is actually in the index so itsmore "real". Closes #70260
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Mar 25, 2021
This restores SQL's test for fetching `half_floats` after we backported the precision change in that fetch (elastic#70653)
nik9000
added a commit
that referenced
this pull request
Mar 26, 2021
This restores SQL's test for fetching `half_floats` after we backported the precision change in that fetch (#70653)
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Mar 26, 2021
Now that elastic#70653 is merged we can send all kinds of strange values to the `fields` round trip test for `half_float`.
nik9000
added a commit
that referenced
this pull request
Apr 2, 2021
Now that #70653 is merged we can send all kinds of strange values to the `fields` round trip test for `half_float`.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Apr 2, 2021
Now that elastic#70653 is merged we can send all kinds of strange values to the `fields` round trip test for `half_float`.
nik9000
added a commit
that referenced
this pull request
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the fields API to return values with half_float's
precision. This makes the fields API better reflect what we've indexed
which we'd like to to do in general. It does make the values that come
back "uglier" because things like
3.14end up becoming3.140625. Butthat is what is actually in the index so itsmore "real".
Closes #70260