Skip to content

Test unrounding half_floats #70937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2021
Merged

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Mar 26, 2021

Now that #70653 is merged we can send all kinds of strange values to the
fields round trip test for half_float.

@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests :Search/Search Search-related issues that do not fall into other categories v8.0.0 v7.13.0 labels Mar 26, 2021
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Mar 26, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@nik9000 nik9000 mentioned this pull request Mar 26, 2021
24 tasks
Now that elastic#70653 is merged we can send all kinds of strange values to the
`fields` round trip test for `half_float`.
Copy link
Contributor

@jtibshirani jtibshirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that we fixed this.

@nik9000 nik9000 merged commit bde105b into elastic:master Apr 2, 2021
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Apr 2, 2021
Now that elastic#70653 is merged we can send all kinds of strange values to the
`fields` round trip test for `half_float`.
nik9000 added a commit that referenced this pull request Apr 2, 2021
Now that #70653 is merged we can send all kinds of strange values to the
`fields` round trip test for `half_float`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v7.13.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants