TSDB: Downsampling support cancelled #88496

weizijun · 2022-07-13T08:23:08Z

support cancel downsampling task:

POST _tasks/oTUltX4IQMOUUVeiohTt8A:12345/_cancel
POST _tasks/_cancel?actions=*rollup_indexer*
POST _tasks/_cancel? parent_task_id=xxx

* upstream/master: (38 commits) Simplify map copying (elastic#88432) Make DiffableUtils.diff implementation agnostic (elastic#88403) Ingest: Start separating Metadata from IngestSourceAndMetadata (elastic#88401) Move runtime fields base scripts out of scripting fields api package. (elastic#88488) Enable TRACE Logging for test and increase timeout (elastic#88477) Mute ReactiveStorageIT#testScaleDuringSplitOrClone (elastic#88480) Track the count of failed invocations since last successful policy snapshot (elastic#88398) Avoid noisy exceptions on data nodes when aborting snapshots (elastic#88476) Fix ReactiveStorageDeciderServiceTests testNodeSizeForDataBelowLowWatermark (elastic#88452) INFO logging of snapshot restore and completion (elastic#88257) unmute test (elastic#88454) Updatable API keys - noop check (elastic#88346) Corrected an incomplete sentence. (elastic#86542) Use consistent shard map type in IndexService (elastic#88465) Stop registering TestGeoShapeFieldMapperPlugin in ESIntegTestCase (elastic#88460) TSDB: RollupShardIndexer logging improvements (elastic#88416) Audit API key ID when create or grant API keys (elastic#88456) Bound random negative size test in SearchSourceBuilderTests#testNegativeSizeErrors (elastic#88457) Updatable API keys - logging audit trail event (elastic#88276) Polish reworked LoggedExec task (elastic#88424) ... # Conflicts: # x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/rollup/v2/RollupShardIndexer.java

elasticmachine · 2022-07-14T08:46:07Z

Pinging @elastic/es-analytics-geo (Team:Analytics)

salvatore-campagna · 2022-07-21T16:19:00Z

x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/rollup/v2/RollupShardIndexer.java

@@ -172,17 +195,23 @@ public void beforeBulk(long executionId, BulkRequest request) {
            public void afterBulk(long executionId, BulkRequest request, BulkResponse response) {
                numIndexed.addAndGet(request.numberOfActions());
                if (response.hasFailures()) {
-                    Map<String, String> failures = Arrays.stream(response.getItems())
+                    List<BulkItemResponse> failedItems = Arrays.stream(response.getItems())


I don't get why we need this change here. failedItems.size() should be equal to failures.size(). Isn't enough to just call status.setCancelled()?

when the _id is null, the map key is the same, so the failures.size() is 1, so I use a list to same the failures

salvatore-campagna · 2022-07-21T16:25:26Z

...ugin/rollup/src/test/java/org/elasticsearch/xpack/rollup/v2/RollupActionSingleNodeTests.java

@@ -114,7 +120,7 @@ public void setup() {
        rollupIndex = "rollup-" + sourceIndex;
        startTime = randomLongBetween(946769284000L, 1607470084000L); // random date between 2000-2020
        docCount = randomIntBetween(10, 9000);
-        numOfShards = randomIntBetween(1, 4);
+        numOfShards = 4;// randomIntBetween(1, 4);


Why not setting this value randomly?

Why not setting this value randomly?

sorry, I will revert it

salvatore-campagna · 2022-07-21T16:27:22Z

...ugin/rollup/src/test/java/org/elasticsearch/xpack/rollup/v2/RollupActionSingleNodeTests.java

+        IndicesService indexServices = getInstanceFromNode(IndicesService.class);
+        Index srcIndex = resolveIndex(sourceIndex);
+        IndexService indexService = indexServices.indexServiceSafe(srcIndex);
+        IndexShard shard = indexService.getShard(0);


Should we select the shard randomly?

Should we select the shard randomly?

ok

salvatore-campagna · 2022-11-02T10:14:35Z

@weizijun do you mind updating this PR so to resolve conflicts? We are reviewing it and considering merging it. Thanks.

weizijun · 2022-11-03T02:00:42Z

@weizijun do you mind updating this PR so to resolve conflicts? We are reviewing it and considering merging it. Thanks.

Okay!

* main: (1300 commits) update c2id/c2id-server-demo docker image to support ARM (elastic#91144) Allow legacy index settings on legacy indices (elastic#90264) Skip prevoting if single-node discovery (elastic#91255) Chunked encoding for snapshot status API (elastic#90801) Allow different decay values depending on the score function (elastic#91195) Fix handling indexed envelopes crossing the dateline in mvt API (elastic#91105) Ensure cleanups succeed in JoinValidationService (elastic#90601) Add overflow behaviour test for RecyclerBytesStreamOutput (elastic#90638) More actionable error for ancient indices (elastic#91243) Fix APM configuration file delete (elastic#91058) Clean up handshake test class (elastic#90966) Improve H3#hexRing logic and add H3#areNeighborCells method (elastic#91140) Restrict direct use of `ApplicationPrivilege` constructor (elastic#91176) [ML] Allow NLP truncate option to be updated when span is set (elastic#91224) Support multi-intersection for FieldPermissions (elastic#91169) Support intersecting multi-sets of queries with DocumentPermissions (elastic#91151) Ensure TermsEnum action works correctly with API keys (elastic#91170) Fix NPE in auditing authenticationSuccess for non-existing run-as user (elastic#91171) Ensure PKI's delegated_by_realm metadata respect run-as (elastic#91173) [ML] Update API documentation for anomaly score explanation (elastic#91177) ... # Conflicts: # x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/XPackClientPlugin.java # x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/downsample/RollupShardIndexer.java # x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/downsample/TransportRollupIndexerAction.java # x-pack/plugin/rollup/src/test/java/org/elasticsearch/xpack/rollup/v2/RollupActionSingleNodeTests.java

martijnvg · 2022-11-03T07:01:36Z

@elasticmachine test this please

weizijun · 2022-11-03T08:06:58Z

@salvatore-campagna @martijnvg there is a notice: the RollupShardStatus is referenced by RollupShardIndexer. I'm not sure if RollupShardStatus will change the reference.
If the reference changes, the new RollupShardStatus changed to ABORT, but the old RollupShardStatus reference by RollupShardIndexer don't changed, so the task can not be stopped.

martijnvg

Thanks @weizijun for working on this. I left comments around the integration with the task framework.

martijnvg · 2022-11-03T07:33:59Z

.../plugin/core/src/main/java/org/elasticsearch/xpack/core/rollup/action/RollupShardStatus.java

+
+import static org.elasticsearch.xcontent.ConstructingObjectParser.constructorArg;
+
+public class RollupShardStatus implements Task.Status {


Can the status class be immutable? Typically the task class has modifiable state and when we create the status class it reads fields from the task and then this status class is immutable (an immutable view of the state).

The RollupShardTask should then contain the AtomicInteger counters and the this class should then be passed down to RollupShardIndexer.

For an example you can take a look at reindex, at the BulkByScrollTask and BulkByScrollTask.Status classes.

martijnvg · 2022-11-03T08:10:56Z

...in/rollup/src/main/java/org/elasticsearch/xpack/downsample/TransportRollupIndexerAction.java

@@ -170,9 +179,12 @@ protected RollupIndexerAction.Response newResponse(
    private class Async extends AsyncBroadcastAction {
        private final RollupIndexerAction.Request request;
        private final ActionListener<RollupIndexerAction.Response> listener;
+        private final Task task;
+        private boolean hasCancelled = false;


I don't think I fully understand that the changes to the Async inner class.
It seems to always cancel a shard level rollup before actually performing it?

I think I understand now, why this logic is added and how it works. This for cancelling other shard level operations in case one fails. Downsampling may take a long time to complete and if a downsample fails in one shard, this can speed up the response to the client.

Should the hasCancelled field be volatile? I think it will read / updated from different threads.

I also don't see this change. Maybe you forgot to push it?

martijnvg · 2022-11-03T08:18:45Z

x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/downsample/RollupShardIndexer.java

@@ -90,11 +92,15 @@ class RollupShardIndexer {
    private final String[] metricFields;
    private final String[] labelFields;
    private final Map<String, FieldValueFetcher> fieldValueFetchers;
+    private final AtomicLong numReceived = new AtomicLong();


Maybe these counters should be moved to the RollupShardTask class? If this class has access to the task then it can just increments these counters that are part of the task. I think makes managing these counters easier.

martijnvg · 2022-11-03T08:29:32Z

the RollupShardStatus is referenced by RollupShardIndexer. I'm not sure if RollupShardStatus will change the reference.
If the reference changes, the new RollupShardStatus changed to ABORT, but the old RollupShardStatus reference by RollupShardIndexer don't changed, so the task can not be stopped.

I think status classes aren't meant to be passed around to other components and keep track of state. This what the task class is for. When an action executes there should be only one task instance and that should exist until the operation completed (either successfully or failed). In this case for downsampling, a task (created by RollupIndexerAction) will be created for each shard and also a task instance when TransportRollupAction invokes the rollup indexer action action.

martijnvg

Thanks @weizijun. I did another review round.

martijnvg · 2022-11-10T12:19:55Z

.../plugin/core/src/main/java/org/elasticsearch/xpack/core/rollup/action/RollupShardStatus.java

+
+    private final ShardId shardId;
+    private final long rollupStart;
+    private final AtomicLong numReceived;


Change the num* fields to type long?

These fields are still AtomicLong, can you change the type of the fields field long?

martijnvg · 2022-11-10T12:20:33Z

...ck/plugin/core/src/main/java/org/elasticsearch/xpack/core/rollup/action/RollupShardTask.java

+
+public class RollupShardTask extends CancellableTask {
+    private String rollupIndex;
+    private DownsampleConfig config;


I think rollupIndex and config fields can also be final fields?

These fields are still not final?

martijnvg · 2022-11-10T12:23:35Z

x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/downsample/RollupShardIndexer.java

-    private final AtomicLong numSent = new AtomicLong();
-    private final AtomicLong numIndexed = new AtomicLong();
-    private final AtomicLong numFailed = new AtomicLong();
+    private final AtomicLong numReceived;


Maybe use the use getters on the task object directly? Instead of also defining these fields here.

There is a reference to the task here. So I think the atomic long fields can be removed here and
instead the atomic longs from the RollupShardTask can be used directly in this class.

Can you also make this (^) change?

martijnvg · 2022-11-10T12:26:04Z

...ck/plugin/core/src/main/java/org/elasticsearch/xpack/core/rollup/action/RollupShardTask.java

+
+    @Override
+    public Status getStatus() {
+        return status;


Instead of creating a status object in the constructor. The status object should be created in this method.
This way a read only copy of the status of the task is created. And then there is no need to pass the atomic longs to the status.

Yeah, I change the code.

This method should return a new status instance:

new RollupShardStatus(shardId, numReceived, numSent, numIndexed, numFailed);

and then the status field in this class can be removed.

martijnvg · 2022-11-10T12:35:47Z

...in/rollup/src/main/java/org/elasticsearch/xpack/downsample/TransportRollupIndexerAction.java

@@ -170,9 +179,12 @@ protected RollupIndexerAction.Response newResponse(
    private class Async extends AsyncBroadcastAction {
        private final RollupIndexerAction.Request request;
        private final ActionListener<RollupIndexerAction.Response> listener;
+        private final Task task;
+        private boolean hasCancelled = false;


I think I understand now, why this logic is added and how it works. This for cancelling other shard level operations in case one fails. Downsampling may take a long time to complete and if a downsample fails in one shard, this can speed up the response to the client.

martijnvg · 2022-11-10T12:39:43Z

...in/rollup/src/main/java/org/elasticsearch/xpack/downsample/TransportRollupIndexerAction.java

@@ -170,9 +179,12 @@ protected RollupIndexerAction.Response newResponse(
    private class Async extends AsyncBroadcastAction {
        private final RollupIndexerAction.Request request;
        private final ActionListener<RollupIndexerAction.Response> listener;
+        private final Task task;
+        private boolean hasCancelled = false;


Should the hasCancelled field be volatile? I think it will read / updated from different threads.

martijnvg · 2022-11-10T12:47:06Z

...in/rollup/src/main/java/org/elasticsearch/xpack/downsample/TransportRollupIndexerAction.java

@@ -50,6 +55,7 @@ public class TransportRollupIndexerAction extends TransportBroadcastAction<
    private final Client client;
    private final ClusterService clusterService;
    private final IndicesService indicesService;
+    private final TransportCancelTasksAction cancelTasksAction;


Maybe use the client field here instead of adding cancelTasksAction here? The cancel task action is available in ClusterAdminClient.

I think the cancelTasksAction field can be removed here and just use client here to invoke the cancel action.

martijnvg · 2022-11-10T12:55:55Z

...in/rollup/src/main/java/org/elasticsearch/xpack/downsample/TransportRollupIndexerAction.java

+        @Override
+        protected void onOperation(@Nullable ShardRouting shard, final ShardIterator shardIt, int shardIndex, Exception e) {
+            // when this shard operation failed, cancel other shard operations
+            cancelOtherShardIndexers();


In case a shard has replicas the behaviour of the super class is to retry on the replica shard.
With the cancel logic, I don't think we want this?

When do you want cancelOtherShardIndexers to be called? I change the code, when the shard failed, to avoid retry, I set the shardIt to the last shard.

I change the code, when the shard failed, to avoid retry, I set the shardIt to the last shard.

👍

x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/downsample/RollupShardIndexer.java

* main: (163 commits) [DOCS] Edits frequent items aggregation (elastic#91564) Handle providers of optional services in ubermodule classloader (elastic#91217) Add `exportDockerImages` lifecycle task for exporting docker tarballs (elastic#91571) Fix CSV dependency report output file location in DRA CI job Fix variable placeholder for Strings.format calls (elastic#91531) Fix output dir creation in ConcatFileTask (elastic#91568) Fix declaration of dependencies in DRA snapshots CI job (elastic#91569) Upgrade Gradle Enterprise plugin to 3.11.4 (elastic#91435) Ingest DateProcessor (small) speedup, optimize collections code in DateFormatter.forPattern (elastic#91521) Fix inter project handling of generateDependenciesReport (elastic#91555) [Synthetics] Add synthetics-* read to fleet-server (elastic#91391) [ML] Copy more settings when creating DF analytics destination index (elastic#91546) Reduce CartesianCentroidIT flakiness (elastic#91553) Propagate last node to reinitialized routing tables (elastic#91549) Forecast write load during rollovers (elastic#91425) [DOCS] Warn about potential overhead of named queries (elastic#91512) Datastream unavailable exception metadata (elastic#91461) Generate docker images and dependency report in DRA ci job (elastic#91545) Support cartesian_bounds aggregation on point and shape (elastic#91298) Add support for EQL samples queries (elastic#91312) ... # Conflicts: # x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/downsample/RollupShardIndexer.java

martijnvg

I did another review round. I think some changes were not pushed? I don't see some of the changes you said you've done.

martijnvg · 2022-11-17T08:02:03Z

...ck/plugin/core/src/main/java/org/elasticsearch/xpack/core/rollup/action/RollupShardTask.java

+
+    @Override
+    public Status getStatus() {
+        return status;


This method should return a new status instance:

new RollupShardStatus(shardId, numReceived, numSent, numIndexed, numFailed);

and then the status field in this class can be removed.

martijnvg · 2022-11-17T08:02:16Z

...ck/plugin/core/src/main/java/org/elasticsearch/xpack/core/rollup/action/RollupShardTask.java

+
+public class RollupShardTask extends CancellableTask {
+    private String rollupIndex;
+    private DownsampleConfig config;


These fields are still not final?

x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/downsample/RollupShardIndexer.java

martijnvg · 2022-11-17T08:08:06Z

...in/rollup/src/main/java/org/elasticsearch/xpack/downsample/TransportRollupIndexerAction.java

@@ -50,6 +55,7 @@ public class TransportRollupIndexerAction extends TransportBroadcastAction<
    private final Client client;
    private final ClusterService clusterService;
    private final IndicesService indicesService;
+    private final TransportCancelTasksAction cancelTasksAction;


I think the cancelTasksAction field can be removed here and just use client here to invoke the cancel action.

martijnvg · 2022-11-17T08:09:51Z

...in/rollup/src/main/java/org/elasticsearch/xpack/downsample/TransportRollupIndexerAction.java

@@ -170,9 +179,12 @@ protected RollupIndexerAction.Response newResponse(
    private class Async extends AsyncBroadcastAction {
        private final RollupIndexerAction.Request request;
        private final ActionListener<RollupIndexerAction.Response> listener;
+        private final Task task;
+        private boolean hasCancelled = false;


I also don't see this change. Maybe you forgot to push it?

martijnvg · 2022-11-17T08:10:24Z

...in/rollup/src/main/java/org/elasticsearch/xpack/downsample/TransportRollupIndexerAction.java

+                    task,
+                    new CancelTasksRequest().setTargetParentTaskId(new TaskId(clusterService.localNode().getId(), task.getId())),
+                    ActionListener.wrap(r -> {
+                        logger.info("[{}] rollup cancel other shard indexers", request.getRollupRequest().getSourceIndex());


I also don't see this change. Maybe you forgot to push it?

martijnvg · 2022-11-17T08:11:43Z

x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/downsample/RollupShardIndexer.java

-    private final AtomicLong numSent = new AtomicLong();
-    private final AtomicLong numIndexed = new AtomicLong();
-    private final AtomicLong numFailed = new AtomicLong();
+    private final AtomicLong numReceived;


There is a reference to the task here. So I think the atomic long fields can be removed here and
instead the atomic longs from the RollupShardTask can be used directly in this class.

weizijun · 2022-11-17T09:34:15Z

I did another review round. I think some changes were not pushed? I don't see some of the changes you said you've done.

Sorry, I lost some changes, now I have pushed them.

martijnvg · 2022-11-17T09:46:26Z

.../plugin/core/src/main/java/org/elasticsearch/xpack/core/rollup/action/RollupShardStatus.java

+
+    private final ShardId shardId;
+    private final long rollupStart;
+    private final AtomicLong numReceived;


These fields are still AtomicLong, can you change the type of the fields field long?

martijnvg · 2022-11-17T09:48:39Z

x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/downsample/RollupShardIndexer.java

-    private final AtomicLong numSent = new AtomicLong();
-    private final AtomicLong numIndexed = new AtomicLong();
-    private final AtomicLong numFailed = new AtomicLong();
+    private final AtomicLong numReceived;


Can you also make this (^) change?

martijnvg · 2022-11-17T09:50:36Z

...in/rollup/src/main/java/org/elasticsearch/xpack/downsample/TransportRollupIndexerAction.java

+        @Override
+        protected void onOperation(@Nullable ShardRouting shard, final ShardIterator shardIt, int shardIndex, Exception e) {
+            // when this shard operation failed, cancel other shard operations
+            cancelOtherShardIndexers();


I change the code, when the shard failed, to avoid retry, I set the shardIt to the last shard.

👍

martijnvg · 2022-11-17T09:51:08Z

...in/rollup/src/main/java/org/elasticsearch/xpack/downsample/TransportRollupIndexerAction.java

@@ -170,9 +177,12 @@ protected RollupIndexerAction.Response newResponse(
    private class Async extends AsyncBroadcastAction {
        private final RollupIndexerAction.Request request;
        private final ActionListener<RollupIndexerAction.Response> listener;
+        private final Task task;
+        private volatile boolean hasCancelled = false;


Maybe rename to hasCancelledOtherShardOperations?

martijnvg

I left one smaller comment and a bigger comment around cancelling shard level downsamples in case a single shard level downsample fails. I think it is fragile, and I don't have a good idea how to make this more robust. Maybe leave this out of this PR? So that we can get the rest of the PR merged? If you like then the shard level downsample cancelling in case of failure can be explored/developed in another PR.

martijnvg · 2022-11-21T08:55:36Z

...ck/plugin/core/src/main/java/org/elasticsearch/xpack/core/rollup/action/RollupShardTask.java

+
+    @Override
+    public Status getStatus() {
+        return new RollupShardStatus(shardId, rollupStartTime, numReceived, numSent, numIndexed, numFailed);


Change return new RollupShardStatus(shardId, rollupStartTime, numReceived, numSent, numIndexed, numFailed); into return new RollupShardStatus(shardId, rollupStartTime.get(), numReceived.get(), numSent.get(), numIndexed.get(), numFailed.get()); and then the fields in RollupShardStatus that are of type AtomicLong should be changed to long.

martijnvg · 2022-11-21T13:47:40Z

...in/rollup/src/main/java/org/elasticsearch/xpack/downsample/TransportRollupIndexerAction.java

@@ -186,5 +196,42 @@ protected void finishHim() {
                listener.onFailure(e);
            }
        }
+


After some more thinking, I'm not comfortable this particular change (cancelling other shard level downsamples incase a shard level downsample fails). I think in the current state it is fragile. I don't have a good suggestion how to make this logic more robust.

okay, I removed these code.

martijnvg · 2022-11-21T13:53:05Z

@elasticmachine test this please

* upstream/main: (209 commits) Remove unused methods and classes from HLRC (elastic#92030) Clean up on exception while chunking XContent (elastic#92024) Add profiling plugin (elastic#91640) Remove unused methods and classes from HLRC (elastic#92012) Remove IndexerState from HLRC (elastic#92023) Ensure cached time elapses in ClusterServiceIT (elastic#91986) Chunked encoding for RestGetIndicesAction (elastic#92016) Simplify shardsWithState (elastic#91991) [DOCS] Updates ML decider docs by mentioning CPU as scaling criterion (elastic#92018) Add chunking to ClusterState.Custom impls (elastic#91963) Speedup time_series agg by caching current tsid ordinal, parent bucket ordinal and buck ordinal (elastic#91784) Drop the ingest listener call count tracking (elastic#92003) [DOCS] fixes issue number 91889 - missing [discrete] header (elastic#91976) Fix PersistentTasksClusterServiceTests (elastic#92002) [docs] Update search-settings documentation to reflect the fact that the indices.query.bool.max_clause_count setting has been deprecated (elastic#91811) Clarify writability in Netty4HttpPipeliningHandler (elastic#91982) Load stable plugins as synthetic modules (elastic#91869) Handle any exception thrown while generating source for an IngestDocument (elastic#91981) fixing Apache HttpHost url on java-rest doc (elastic#91945) Implement repair functionality for aliases colliding with indices bug (elastic#91887) ...

martijnvg

Thanks @weizijun! I left one minor comment, but other than that this looks good to me.

martijnvg · 2022-12-02T13:58:27Z

...ck/plugin/core/src/main/java/org/elasticsearch/xpack/core/rollup/action/RollupShardTask.java

+        return new RollupShardStatus(shardId, rollupStartTime, numReceived.get(), numSent.get(), numIndexed.get(), numFailed.get());
+    }
+
+    public long getNumReceived() {


Maybe just have getter methods for the AtomicLong fields?

martijnvg · 2022-12-02T13:59:36Z

@elasticmachine test this please

martijnvg · 2022-12-05T14:31:01Z

@elasticmachine update branch

martijnvg · 2022-12-05T14:31:27Z

@elasticmachine test this please

martijnvg · 2022-12-05T16:56:34Z

@elasticmachine run elasticsearch-ci/packaging-tests-windows-sample

weizijun added 3 commits July 12, 2022 16:13

support task cancel

d02067d

cancel task when bulk failed

a39ae4e

elasticsearchmachine added v8.4.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jul 13, 2022

add rollup bulk failed test

fb3d7ab

csoulios requested review from salvatore-campagna and csoulios July 13, 2022 09:54

csoulios self-assigned this Jul 13, 2022

csoulios added >non-issue :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data labels Jul 13, 2022

weizijun added 2 commits July 14, 2022 16:39

when write rollup index docs failed, cancel the rollup task

ab8ca06

support task cancel

b7dfa21

weizijun marked this pull request as ready for review July 14, 2022 08:46

elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jul 14, 2022

weizijun changed the title ~~[WIP]TSDB: Downsampling support cancelled~~ TSDB: Downsampling support cancelled Jul 14, 2022

salvatore-campagna reviewed Jul 21, 2022

View reviewed changes

improve

d15cb1c

elasticsearchmachine changed the base branch from master to main July 22, 2022 23:05

mark-vieira added v8.5.0 and removed v8.4.0 labels Jul 27, 2022

csoulios mentioned this pull request Jul 29, 2022

Add better support for metric data types (TSDB) #74660

Closed

csoulios added v8.6.0 and removed v8.5.0 labels Sep 21, 2022

martijnvg self-requested a review November 2, 2022 10:12

weizijun added 2 commits November 3, 2022 11:08

fixup

1d28c3b

martijnvg requested changes Nov 3, 2022

View reviewed changes

improve

558bf0a

martijnvg reviewed Nov 10, 2022

View reviewed changes

weizijun added 3 commits November 15, 2022 14:16

improve

1fae1d6

improve

c8e1584

kingherc added v8.7.0 and removed v8.6.0 labels Nov 16, 2022

martijnvg reviewed Nov 17, 2022

View reviewed changes

improve

f5f544f

martijnvg reviewed Nov 17, 2022

View reviewed changes

weizijun added 2 commits November 18, 2022 11:15

improve stats

18f2432

change name

ad7d1c3

martijnvg reviewed Nov 21, 2022

View reviewed changes

weizijun added 2 commits December 1, 2022 10:47

improve

e745cb7

martijnvg approved these changes Dec 2, 2022

View reviewed changes

Merge branch 'main' into rollup-support-cancel

b97e7ca

martijnvg merged commit 5e7c417 into elastic:main Dec 6, 2022


		import static org.elasticsearch.xcontent.ConstructingObjectParser.constructorArg;

		public class RollupShardStatus implements Task.Status {

TSDB: Downsampling support cancelled #88496

TSDB: Downsampling support cancelled #88496

Uh oh!

Conversation

weizijun commented Jul 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Jul 14, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

salvatore-campagna commented Nov 2, 2022

Uh oh!

weizijun commented Nov 3, 2022

Uh oh!

martijnvg commented Nov 3, 2022

Uh oh!

weizijun commented Nov 3, 2022

Uh oh!

martijnvg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

martijnvg commented Nov 3, 2022

Uh oh!

martijnvg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

weizijun commented Jul 13, 2022 •

edited

Loading