-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Test that malformed HTTP request is not validated #95886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test that malformed HTTP request is not validated #95886
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - However, I also don't have enough experience to advise on the quality or coverage of the tests. The comments help and to the best of my ability they appear solid but if you are looking for critical feedback on details of what/how to test you may want to seek an additional reviewer (but that is not necessary since these are just tests).
It's tricky to asses the coverage when interfacing so closely with the netty code, as the API surface is large and not explicitly defined (it's only defined by the object types, and their order, as they flow through the pipeline from request decoding through aggregation). This PR only covers a single case/observation: when there's a HTTP decoding error, a new FullHttpRequest is generated rather than a HttpRequest, as is normally the case. So, the tests in The tests in |
This PR tests that malformed HTTP requests that fail at the decoding stage don't go through validation and are further dispatched as bad requests. Related: elastic#95112
This PR tests that malformed HTTP requests that
fail at the decoding stage don't go through validation and
are further dispatched as bad requests.
Related: #95112