Skip to content

[CI] SecurityNetty4HttpServerTransportTests testMalformedRequestDispatchedNoAuthn failing #95983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thecoop opened this issue May 10, 2023 · 2 comments · Fixed by #96178
Closed

[CI] SecurityNetty4HttpServerTransportTests testMalformedRequestDispatchedNoAuthn failing #95983

thecoop opened this issue May 10, 2023 · 2 comments · Fixed by #96178
Assignees
@albertzaharovits
Labels
:Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Security Meta label for security team >test-failure Triaged test failures from CI

Comments

@thecoop
Copy link
Member

thecoop commented May 10, 2023 •
edited
Loading

Introduced by #95886. We've got a turkish I here causing string equality mismatch

Build scan:
https://gradle-enterprise.elastic.co/s/iik5gi62i5sdq/tests/:x-pack:plugin:security:test/org.elasticsearch.xpack.security.transport.netty4.SecurityNetty4HttpServerTransportTests/testMalformedRequestDispatchedNoAuthn

Reproduction line:

./gradlew ':x-pack:plugin:security:test' --tests "org.elasticsearch.xpack.security.transport.netty4.SecurityNetty4HttpServerTransportTests.testMalformedRequestDispatchedNoAuthn" -Dtests.seed=A4B64B6F13AB9626 -Dtests.locale=tr -Dtests.timezone=US/Indiana-Starke -Druntime.java=20

Applicable branches:
main

Reproduces locally?:
Yes

Failure history:
https://gradle-enterprise.elastic.co/scans/tests?tests.container=org.elasticsearch.xpack.security.transport.netty4.SecurityNetty4HttpServerTransportTests&tests.test=testMalformedRequestDispatchedNoAuthn

Failure excerpt:

java.lang.AssertionError: 
Expected: a string containing "NOT A VALID HTTP LINE"
     but: was "java.lang.IllegalArgumentException: invalid version format: NOT A VALİD HTTP LİNE"

  at __randomizedtesting.SeedInfo.seed([A4B64B6F13AB9626:D95AF3108B934C8B]:0)
  at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
  at org.junit.Assert.assertThat(Assert.java:956)
  at org.junit.Assert.assertThat(Assert.java:923)
  at org.elasticsearch.xpack.security.transport.netty4.SecurityNetty4HttpServerTransportTests.testMalformedRequestDispatchedNoAuthn(SecurityNetty4HttpServerTransportTests.java:584)
  at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
  at java.lang.reflect.Method.invoke(Method.java:578)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:48)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:843)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:490)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:850)
  at java.lang.Thread.run(Thread.java:1623)
@thecoop thecoop added :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) >test-failure Triaged test failures from CI labels May 10, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@elasticsearchmachine elasticsearchmachine added the Team:Security Meta label for security team label May 10, 2023
@albertzaharovits
Copy link
Contributor

ACK, will push a fix tomorrow.

@danielmitterdorfer danielmitterdorfer mentioned this issue May 11, 2023
Merged
@pxsalehi pxsalehi mentioned this issue May 16, 2023
Merged
@albertzaharovits albertzaharovits mentioned this issue May 16, 2023
Merged
albertzaharovits added a commit that referenced this issue May 17, 2023
@albertzaharovits
Fix SecurityNetty4HttpServerTransportTests (#96178)
92b289a 
Skips SecurityNetty4HttpServerTransportTests
testMalformedRequestDispatchedNoAuthn
under turkish-like locales because the asserted
messages are internally processed with
String#toUpper(). This results in different
error messages under such locales, and it's
easier to skip the test entirely than to assert
the different messages.

Closes: #95983
albertzaharovits added a commit to albertzaharovits/elasticsearch that referenced this issue Jun 19, 2023
@albertzaharovits
Fix SecurityNetty4HttpServerTransportTests (elastic#96178)
1483bf7 
Skips SecurityNetty4HttpServerTransportTests
testMalformedRequestDispatchedNoAuthn
under turkish-like locales because the asserted
messages are internally processed with
String#toUpper(). This results in different
error messages under such locales, and it's
easier to skip the test entirely than to assert
the different messages.

Closes: elastic#95983
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@albertzaharovits albertzaharovits

Labels
:Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Security Meta label for security team >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix SecurityNetty4HttpServerTransportTests albertzaharovits/elasticsearch
3 participants
@thecoop @albertzaharovits @elasticsearchmachine