-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Check shard availability before including in stats #96015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
danielmitterdorfer
merged 3 commits into
elastic:main
from
danielmitterdorfer:check-shard-stats
May 11, 2023
Merged
Check shard availability before including in stats #96015
danielmitterdorfer
merged 3 commits into
elastic:main
from
danielmitterdorfer:check-shard-stats
May 11, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we check whether there is an available shard routing before we test whether it has been started. This makes `DataTiersUsageTransportAction` more resilient to potential temporary inconsistencies between cluster state and node stats due to concurrent shard movement. Closes elastic#87001 Closes elastic#96000
Pinging @elastic/es-data-management (Team:Data Management) |
Hi @danielmitterdorfer, I've created a changelog YAML for you. |
This was referenced May 11, 2023
One check failed due to #95983. @elasticmachine run elasticsearch-ci/part-3 |
gmarouli
approved these changes
May 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @danielmitterdorfer thank you for fixing this!
💚 Backport successful
|
danielmitterdorfer
added a commit
to danielmitterdorfer/elasticsearch
that referenced
this pull request
May 11, 2023
With this commit we check whether there is an available shard routing before we test whether it has been started. This makes `DataTiersUsageTransportAction` more resilient to potential temporary inconsistencies between cluster state and node stats due to concurrent shard movement. Closes elastic#87001 Closes elastic#96000
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 11, 2023
With this commit we check whether there is an available shard routing before we test whether it has been started. This makes `DataTiersUsageTransportAction` more resilient to potential temporary inconsistencies between cluster state and node stats due to concurrent shard movement. Closes #87001 Closes #96000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we check whether there is an available shard routing before we test whether it has been started. This makes
DataTiersUsageTransportAction
more resilient to potential temporary inconsistencies between cluster state and node stats due to concurrent shard movement.Closes #87001
Closes #96000