Skip to content

Check shard availability before including in stats #96015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 11, 2023

Conversation

danielmitterdorfer
Copy link
Member

With this commit we check whether there is an available shard routing before we test whether it has been started. This makes DataTiersUsageTransportAction more resilient to potential temporary inconsistencies between cluster state and node stats due to concurrent shard movement.

Closes #87001
Closes #96000

With this commit we check whether there is an available shard routing
before we test whether it has been started. This makes
`DataTiersUsageTransportAction` more resilient to potential temporary
inconsistencies between cluster state and node stats due to concurrent
shard movement.

Closes elastic#87001
Closes elastic#96000
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine
Copy link
Collaborator

Hi @danielmitterdorfer, I've created a changelog YAML for you.

@danielmitterdorfer
Copy link
Member Author

One check failed due to #95983.

@elasticmachine run elasticsearch-ci/part-3

@gmarouli gmarouli self-requested a review May 11, 2023 08:21
Copy link
Contributor

@gmarouli gmarouli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @danielmitterdorfer thank you for fixing this!

@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.8

danielmitterdorfer added a commit to danielmitterdorfer/elasticsearch that referenced this pull request May 11, 2023
With this commit we check whether there is an available shard routing
before we test whether it has been started. This makes
`DataTiersUsageTransportAction` more resilient to potential temporary
inconsistencies between cluster state and node stats due to concurrent
shard movement.

Closes elastic#87001
Closes elastic#96000
elasticsearchmachine pushed a commit that referenced this pull request May 11, 2023
With this commit we check whether there is an available shard routing
before we test whether it has been started. This makes
`DataTiersUsageTransportAction` more resilient to potential temporary
inconsistencies between cluster state and node stats due to concurrent
shard movement.

Closes #87001
Closes #96000
@gmarouli gmarouli added v8.8.0 and removed v8.8.1 labels May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug Team:Data Management Meta label for data/management team v8.8.0 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] TransformUsageIT testUsage failing NPE in DataTiersUsageTransportAction
3 participants