Refactor settings filtering, adding regex support #9748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imotov
added
>enhancement
>breaking
v2.0.0-beta1
:Core/Infra/Core
| settingsFilter.addFilter("index.filter_test.foo"); | ||
| settingsFilter.addFilter("index.filter_test.bar*"); | ||
| } | ||
|
|
|
left some minor comments - I'd love a untitest for the |
|
@s1monw I added the unit test |
|
LGTM |
Refactor how settings filters are handled. Instead of specifying settings filters as filtering class, settings filters are now specified as list of settings that needs to be filtered out. Regex syntax is supported. This is breaking change and will require small change in plugins that are using settingsFilters. This change is needed in order to simplify cluster state diff implementation. Contributes to elastic#6295
imotov
force-pushed
the
refactor-settings-filter
branch
from
b6c152c to
432f578
Compare
imotov
added a commit
to imotov/elasticsearch-cloud-aws
that referenced
this pull request
Feb 24, 2015
Update settings filter to match elastic/elasticsearch#9748
dadoonet
added a commit
to dadoonet/elasticsearch-cloud-azure
that referenced
this pull request
Feb 27, 2015
Update settings filter to match elastic/elasticsearch#9748 Closes elastic#71.
dadoonet
added a commit
to dadoonet/elasticsearch-cloud-azure
that referenced
this pull request
Mar 28, 2015
Update settings filter to match elastic/elasticsearch#9748 Closes elastic#71.
dadoonet
added a commit
to dadoonet/elasticsearch-cloud-azure
that referenced
this pull request
Apr 16, 2015
…ponent Update settings filter to match elastic/elasticsearch#9748 Remove component settings from AbstractComponent as seen in elastic/elasticsearch#9919 Closes elastic#71. Closes elastic#72.
dadoonet
added a commit
to elastic/elasticsearch-cloud-azure
that referenced
this pull request
Apr 16, 2015
…ponent Update settings filter to match elastic/elasticsearch#9748 Remove component settings from AbstractComponent as seen in elastic/elasticsearch#9919 Closes #71. Closes #72. (cherry picked from commit cd7b8d4)
dadoonet
added a commit
to elastic/elasticsearch-cloud-azure
that referenced
this pull request
Apr 16, 2015
…ponent Update settings filter to match elastic/elasticsearch#9748 Remove component settings from AbstractComponent as seen in elastic/elasticsearch#9919 Closes #71. Closes #72. (cherry picked from commit cd7b8d4)
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor how settings filters are handled. Instead of specifying settings filters as filtering class, settings filters are now specified as list of settings that needs to be filtered out. Regex syntax is supported. This is breaking change and will require small change in plugins that are using settingsFilters. This change is needed in order to simplify cluster state diff implementation.
Contributes to #6295