Remove component settings from AbstractComponent #9919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we have two ways of getting a setting, either with the full settings key or with only the last part of the key where the prefix is implicit depending on the package the class is in via component settings. this is trappy as well as confusing for users and can break easily if a class is moved to a new package since the prefix then implicitly changes. This commit removes the component settings from the codebase.
|
Note that this will have of course consequences in plugins. Now that we use full path for setting names, could we define static final String for those? |
|
@dadoonet there are no consequences in plugins you always had to specify the full key in the settings. |
|
+1 to have just one way to get settings. |
|
+1 the bwc issues that can happen from moving a class makes component settings trappy. |
|
Forgot to say that I'm +1 as well. |
dadoonet
added a commit
to elastic/elasticsearch-transport-memcached
that referenced
this pull request
Feb 27, 2015
Related to elastic/elasticsearch#9919 Closes #36.
dadoonet
added a commit
to elastic/elasticsearch-transport-thrift
that referenced
this pull request
Feb 27, 2015
Related to elastic/elasticsearch#9919 Closes #44.
dadoonet
added a commit
to elastic/elasticsearch-cloud-aws
that referenced
this pull request
Feb 27, 2015
Related to elastic/elasticsearch#9919 Closes #182.
dadoonet
added a commit
to dadoonet/elasticsearch-cloud-azure
that referenced
this pull request
Feb 27, 2015
dadoonet
added a commit
to dadoonet/elasticsearch-cloud-azure
that referenced
this pull request
Feb 27, 2015
Related to elastic/elasticsearch#9919 Closes elastic#72. (cherry picked from commit db888a5)
dadoonet
added a commit
to elastic/elasticsearch-lang-javascript
that referenced
this pull request
Feb 28, 2015
Related to elastic/elasticsearch#9919 Closes #35.
dadoonet
added a commit
to dadoonet/elasticsearch-cloud-azure
that referenced
this pull request
Mar 28, 2015
dadoonet
added a commit
to dadoonet/elasticsearch-cloud-azure
that referenced
this pull request
Apr 16, 2015
…ponent Update settings filter to match elastic/elasticsearch#9748 Remove component settings from AbstractComponent as seen in elastic/elasticsearch#9919 Closes elastic#71. Closes elastic#72.
dadoonet
added a commit
to elastic/elasticsearch-cloud-azure
that referenced
this pull request
Apr 16, 2015
…ponent Update settings filter to match elastic/elasticsearch#9748 Remove component settings from AbstractComponent as seen in elastic/elasticsearch#9919 Closes #71. Closes #72. (cherry picked from commit cd7b8d4)
dadoonet
added a commit
to elastic/elasticsearch-cloud-azure
that referenced
this pull request
Apr 16, 2015
…ponent Update settings filter to match elastic/elasticsearch#9748 Remove component settings from AbstractComponent as seen in elastic/elasticsearch#9919 Closes #71. Closes #72. (cherry picked from commit cd7b8d4)
dadoonet
added a commit
to elastic/elasticsearch-cloud-gce
that referenced
this pull request
Apr 24, 2015
Related to elastic/elasticsearch#9919 Closes #50.
dadoonet
added a commit
to elastic/elasticsearch-cloud-gce
that referenced
this pull request
Apr 24, 2015
Related to elastic/elasticsearch#9919 Closes #50. (cherry picked from commit c70e32d)
dadoonet
added a commit
to elastic/elasticsearch-cloud-gce
that referenced
this pull request
Apr 24, 2015
Related to elastic/elasticsearch#9919 Closes #50. (cherry picked from commit c70e32d)
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we have two ways of getting a setting, either with the full settings key or with only
the last part of the key where the prefix is implicit depending on the package the class is in via
component settings. this is trappy as well as confusing for users and can break easily if a class is moved
to a new package since the prefix then implicitly changes.
This commit removes the component settings from the codebase.