Skip to content

[ML] Reduce variability in regression and classification results across our target platforms #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 9, 2020
Merged

[ML] Reduce variability in regression and classification results across our target platforms #1127

merged 13 commits into from
Apr 9, 2020

Conversation

tveasey
Copy link
Contributor

@tveasey tveasey commented Apr 7, 2020 •
edited
Loading

This addresses some of the underlying causes for variation in regression and classification results for different platforms: std::log and std::exp don't always agree in the last decimal place and our split order predicate wasn't a total order.

droberts195
droberts195 reviewed Apr 7, 2020
View reviewed changes
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as long as there are no nasty edge cases. Maybe there aren't but a unit test of the extremes would prove it.

droberts195
droberts195 approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

droberts195
droberts195 reviewed Apr 9, 2020
View reviewed changes
@tveasey tveasey changed the title [ML] Regression and classification should produce identical results for all target OS [ML] Reduce differences in regression and classification results between target platforms Apr 9, 2020
@tveasey tveasey merged commit 12b5014 into elastic:master Apr 9, 2020
@tveasey tveasey deleted the os-differences branch April 9, 2020 12:57
@tveasey tveasey changed the title [ML] Reduce differences in regression and classification results between target platforms [ML] Reduce variability in regression and classification results across our target platforms Apr 9, 2020
@tveasey tveasey mentioned this pull request Apr 16, 2020
Merged
tveasey added a commit to tveasey/ml-cpp-1 that referenced this pull request Apr 17, 2020
@tveasey
[ML] Reduce variability in regression and classification results acro…
d0fe5a3 
…ss our target platforms (elastic#1127)
@tveasey tveasey mentioned this pull request Apr 17, 2020
Merged
tveasey added a commit that referenced this pull request Apr 17, 2020
@tveasey
[7.8][ML] Reduce variability in regression and classification results…
c63ddef 
… across our target platforms (#1151)

Backport #1127.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droberts195 droberts195 droberts195 approved these changes

Assignees
No one assigned
Labels
>enhancement :ml/DataFrameAnalysis review v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tveasey @droberts195