Skip to content

[ML] Silence gcc warnings #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 16, 2020
Merged

[ML] Silence gcc warnings #1145

merged 7 commits into from
Apr 16, 2020

Conversation

tveasey
Copy link
Contributor

@tveasey tveasey commented Apr 16, 2020

This fixes warnings being generated by gcc I noticed while working on #1127. These are harmless and mainly -Wconversion.

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tveasey
Copy link
Contributor Author

tveasey commented Apr 16, 2020

retest

@tveasey tveasey merged commit df5232c into elastic:master Apr 16, 2020
@tveasey tveasey deleted the gcc-warnings branch April 16, 2020 19:46
tveasey added a commit to tveasey/ml-cpp-1 that referenced this pull request Apr 17, 2020
tveasey added a commit that referenced this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants