Modify Time.utc_now/1 to allow truncation and add Time.utc_now/2
#14367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Mar 25, 2025
josevalim
reviewed
Mar 25, 2025
lib/elixir/lib/calendar/time.ex
Outdated
| """ | ||
| @doc since: "1.9.0" | ||
| @spec utc_now(:microsecond | :millisecond | :second, Calendar.calendar()) :: t | ||
| def utc_now(time_unit, calendar) when time_unit in [:microsecond, :millisecond, :second] do | ||
| {:ok, _, time, microsecond} = Calendar.ISO.from_unix(:os.system_time(), :native) |
There was a problem hiding this comment.
I'd say we should pass the time unit as argument here:
Suggested change
| {:ok, _, time, microsecond} = Calendar.ISO.from_unix(:os.system_time(), :native) | |
| {:ok, _, time, microsecond} = Calendar.ISO.from_unix(:os.system_time(), time_unit) |
and allow native as time unit, as done in NaiveDateTime.
There was a problem hiding this comment.
This we don't need to truncate after the fact.
There was a problem hiding this comment.
Added :native. I also switched :os.system_time() for System.os_time(time_unit).
Co-authored-by: José Valim <[email protected]>
sabiwara
reviewed
Mar 25, 2025
Co-authored-by: Jean Klingler <[email protected]>
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://groups.google.com/g/elixir-lang-core/c/KvOYiBk1j1Q