Skip to content

Modify Time.utc_now/1 to allow truncation and add Time.utc_now/2 #14367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 37 additions & 3 deletions lib/elixir/lib/calendar/time.ex
Original file line number Diff line number Diff line change
Expand Up @@ -60,17 +60,51 @@ defmodule Time do
@doc """
Returns the current time in UTC.

You can pass a time unit to automatically truncate the resulting time.

The default unit if none gets passed is `:native` which results on a default resolution of microseconds.

## Examples

iex> time = Time.utc_now()
iex> time.hour >= 0
true

iex> time = Time.utc_now(:second)
iex> time.microsecond
{0, 0}

"""
@doc since: "1.4.0"
@spec utc_now(Calendar.calendar()) :: t
def utc_now(calendar \\ Calendar.ISO) do
{:ok, _, time, microsecond} = Calendar.ISO.from_unix(:os.system_time(), :native)
@spec utc_now(Calendar.calendar() | :native | :microsecond | :millisecond | :second) :: t
def utc_now(calendar_or_time_unit \\ Calendar.ISO) do
case calendar_or_time_unit do
unit when unit in [:native, :microsecond, :millisecond, :second] ->
utc_now(unit, Calendar.ISO)

calendar ->
utc_now(:native, calendar)
end
end

@doc """
Returns the current time in UTC, supporting a precision and a specific calendar.

## Examples

iex> time = Time.utc_now(:microsecond, Calendar.ISO)
iex> time.hour >= 0

iex> time = Time.utc_now(:second, Calendar.ISO)
iex> time.microsecond
{0, 0}

"""
@doc since: "1.19.0"
@spec utc_now(:native | :microsecond | :millisecond | :second, Calendar.calendar()) :: t
def utc_now(time_unit, calendar)
when time_unit in [:native, :microsecond, :millisecond, :second] do
{:ok, _, time, microsecond} = Calendar.ISO.from_unix(System.os_time(time_unit), time_unit)
{hour, minute, second} = time

iso_time = %Time{
Expand Down