fuzzy matching #491
Merged
fuzzy matching #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've pushed new commits to make the CI re-run. This is all green now. Anyway, this PR brings elixir_sense up to the latest version that contains the fuzzy matching and updates the tests to avoid failures and reflect the fuzzy behavior. |
lukaszsamson
approved these changes
Feb 23, 2021
axelson
approved these changes
Feb 28, 2021
There was a problem hiding this comment.
This is pretty great! ❤️
In the future we may want to consider making this configurable, but that depends on how much someone wants to keep the strict prefix matching. And it would be nice to not have to maintain the code to support multiple types of matching.
|
🎉 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an accompanying PR for elixir-lsp/elixir_sense#121
@lukaszsamson
CI is going to be red, as expected.
Best way to move forward I guess is,