-
Notifications
You must be signed in to change notification settings - Fork 41
Fuzzy matching #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fuzzy matching #121
Conversation
The behavior is actually the same as String.starts_with?
The suggestion tests are kinda annoying now - they now return a lot more results because of fuzzy matching. EDIT: not only breaking ElixirSense tests but also ElixirLS https://github.com/princemaple/elixir-ls/commits/master |
08ce43f
to
18a5462
Compare
aff6ec6
to
81609e9
Compare
81609e9
to
7b59921
Compare
@lukaszsamson @axelson @msaraiva I'd be most appreciative if some of you could review this before I go and fix the tests in ElixirLS, in case you have a different opinion about how the tests should be fixed. |
Nice work @princemaple. I'm going to test it a bit tomorrow. |
Thanks. I'm quite enjoying it while coding today, so much that I'm willing to fix more tests so I can apply it in more scenarios. |
FYI the past week of using this patch has been very pleasant. |
I did some testing and so far I like how it's working.
Let's do them in follow up PRs. This one is already big. I'm not sure if callbacks, overridable and protocols are good candidates. Apart from those I'd include more suggestions from complete module: elixir/erlang modules, variables, attributes, map/struct keys. Elixir modules would probably work better with some letter downcasing. |
related: elixir-lsp/elixir-ls#466

Only applied fuzzy matching on module functions so far.
All these files could use this polish to enhance UX. How far do we want to go in 1 PR?