Implement auto-installation of fsharp language server #920
Conversation
lsp-fsharp.el
Outdated
|
|
||
| (defun lsp-fsharp--fsac-install () | ||
| "Downloads the latest version of fsautocomplete, and set `lsp-fsharp-server-path'." | ||
| (let ((temp-file (make-temp-file "fsautocomplete" nil ".zip"))) |
There was a problem hiding this comment.
Take a look at emacs-lsp/lsp-python-ms#37 which also handles unzipping but it fallbacks to powershell on windows. We probably need to push up that logic in lsp-mode and then reuse it in lsp-python-ms and dap-mode.
| @@ -77,6 +110,7 @@ | |||
| :major-modes '(fsharp-mode) | |||
| :notification-handlers (ht ("fsharp/notifyCancel" #'ignore) | |||
There was a problem hiding this comment.
not part of this review but you may take a look how do we handle the notifications in lsp-rust and lsp-java and implement the same logic here.
There was a problem hiding this comment.
Maybe I'm missing something really obvious, but they both look rather similar to what I'm doing here. Could you point me to the code that you are referencing?
There was a problem hiding this comment.
Here it is: https://github.com/emacs-lsp/lsp-mode/blob/master/lsp-rust.el#L296 (although I am not 100% sure that the FSharp notifications are progress notifications).
| @@ -121,44 +121,44 @@ | |||
| ~lsp-clients.el~ while others require installing additional packages which provide | |||
| server specific functionality. | |||
|
|
|||
| | Language | Language Server | Built-in | Installation command | Debugger | | |||
There was a problem hiding this comment.
The formatting changes are caused by the fact that one is performing the formatting with links display enabled and the other is performing the alignment with link display disabled(use org-toggle-link-display). Can you do the formatting so we will have only the required changes?
There was a problem hiding this comment.
Ah, nice catch. Fixed!
|
I've been hacking on |
This PR implements auto-installation of the F# language server.