-
Notifications
You must be signed in to change notification settings - Fork 41
Conversation
Close #33. Get the lastest version of MS PYLS from the Microsoft website, and download to the specified path, then setup to lsp automatically. Additional setup is not necessary. It's out of box.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Few minor comments which may or may not be addressed as part of this PR.
((executable-find "powershell") | ||
"powershell -noprofile -noninteractive \ | ||
-nologo -ex bypass Expand-Archive -path '%s' -dest '%s'") | ||
(t nil)))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may consider asking the user to manually unzip the file in case there is no powershell on this PC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The powershell is built-in since Windows 7. And the behavior is same as dap-mode
(dap-utils.el).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then it seems to be ok to rely on that, thank you.
Nice work! A minor issue is that, on windows system, when mspyls is in use, If keep the updated server in a new directory, there must be a file to keep track the latest version, make the extension more complicated... So, maybe some instructions in source file is a good choice. |
@smallzhan Good point! But it's not necessary to handle this scenario. I will add doc strings later. |
@yyoncho I think it's fine to merge now. |
I think Also, is there a |
In general yes, but lsp-mode is expecting the command to finish synchronously. Until this is fixed we might introduce an interactive async version of the installation command.
AFAIK no. |
Close #33.
Get the lastest version of MS PYLS from the Microsoft website, and download to the specified path,
then setup to lsp automatically. Additional setup is not necessary. It's out of box.