-
Notifications
You must be signed in to change notification settings - Fork 119
array indent is not good #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Could you show an example of how it looks when you try to indent it with Emacs, and what you think it should look like? |
With my Emacs, $post=Post::model()->find(array( 'select'=>'title', 'condition'=>'postID=:postID', 'params'=>array(':postID'=>10), )); And i think it might be more good looking to: $post=Post::model()->find(array( 'select'=>'title', 'condition'=>'postID=:postID', 'params'=>array(':postID'=>10), )); |
I have nothing against adding a change like this so I'll try out the code on Emacs Wiki and see how it affects things in general. In your example I agree the second block of code is more readable, so I think it would be preferable to support that. |
I have pushed a patch to modify indentation so it works this way. Thanks eorza for the suggestion. I like this change better. |
emacs-php#29, emacs-php#42 This massively cuts back on the elisp code needed.
This patch adds a few small tweaks to the "How to Contribute" section of the README: 1. Do not make linking contributors names to websites sound mandatory. 2. Add a `#` character before the numbers in `GitHub-Issue` commit message metadata, e.g. `GitHub-Issue: #14`. 3. Replace the "I will..." of bumping the version number to reflect the fact PHP Mode currently has two equal maintainers, who both are free to increase the version number as they deem fit. Signed-off-by: Eric James Michael Ritz <[email protected]>
it's too long, maybe it's my problem.
http://emacswiki.org/emacs/PhpMode#toc16
Some one solve this in emacs wiki.
The text was updated successfully, but these errors were encountered: