Chained method calls aren't indented

[metaturso]

Chained method calls are not aligned to the first object operator in php-mode 1.6.6 and Emacs 24.2.

Indenting a region such as

    $object = new SomeClass();
    $object->method()
           ->another();

produces the same result as previous version of php-mode

    $object = new SomeClass();
    $object->method()
    ->another();

[rev22]

This requires restoring a setting in the major mode definition:

(c-set-offset 'topmost-intro-cont 'c-lineup-cascaded-calls)

I've pushed the fix: 47b371f

[ejmr]

Thanks both for the bug report and the fix guys.

[metaturso]

Hello guys cascaded calls are still not indented properly when not in the global scope, e.g.:

// global scope
$object = new StdClass();
$object->call()
       ->something();

class Whatever
{
    public function __construct()
    {
        $object = new StdClass();
        $object->call()
            ->something();
    }

    public function something()
    {
        $object = new StdClass();
        $object->call()
            ->something();
    }
}

$closure = function() {
    $object = new StdClass();
    $object->call()
    ->something();
};

function something()
{
    $object = new StdClass();
    $object->call()
        ->something();
}

[ejmr]

Thanks for the bug report. I fixed the issue and put the patch into master, along with adding your test case to the file tests/issue-19.php. I am going to close this issue now but please let me know if it fixes the problem for you.

[metaturso]

It does, but it apparently it also does break font locking. I have to issue font-lock-fontify-buffer whenever a change unfontifies the buffer. Can you confirm this behaviour?

[ejmr]

Yes, I can confirm the behavior. It is caused by 78cb2fc which I have reverted for the time being and described in issue #24. My apologies for introducing the font-lock bug. With that reversion in place you should no longer have that issue.

[TatriX]

Is it possible to indent the following:

$object->prop
->foo()
->bar();

if(true) {
    $object->prop
    ->foo()
    ->bar();
}

to this:

$object->prop
       ->foo()
       ->bar();

if(true) {
    $object->prop
           ->foo()
           ->bar();
}

[ejmr]

@TatriX

That should work if you are using the styles (i.e. C-c .) pear, drupal, or wordpress. If it is not working then that is a bug. If you load php-mode-tests.el and run then with M-x ert do they pass? Specifically the test for issue-19? We may need to make that test more stringent.

[TatriX]

I am using a worpress style.

Selector: t
Passed: 9
Failed: 3 (2 unexpected)
Total:  12/12

Started at:   2013-04-13 10:06:34+0400
Finished.
Finished at:  2013-04-13 10:06:35+0400

F.......F..f

F php-mode-test-issue-14
    Array indentation.
    (ert-test-failed
     ((should
       (reduce
    (lambda
      (l r)
      (and l r))
    (php-mode-test-process-magics)))
      :form
      (reduce
       (lambda
     (l r)
     (and l r))
       (nil t t t))
      :value nil))

F php-mode-test-issue-29
    Indentation of anonymous functions as arguments.
    (ert-test-failed
     ((should
       (reduce
    (lambda
      (l r)
      (and l r))
    (php-mode-test-process-magics)))
      :form
      (reduce
       (lambda
     (l r)
     (and l r))
       (nil nil))
      :value nil))

[ejmr]

Thanks for the test output. I will try to figure out the problem.

[fabacino]

Is this still a problem? I cannot reproduce with v1.21

[zonuexe]

I'm closing it because it looks like there is no problem today.