Avoid setting EM_CACHE unless we really need to
#797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
avoid_em_cache_env_var
branch
from
174964b to
646041b
Compare
sbc100
force-pushed
the
avoid_em_cache_env_var
branch
3 times, most recently
from
3b701a4 to
4017340
Compare
kripken
reviewed
Apr 23, 2021
|
I verified this locally by installing |
sbc100
force-pushed
the
avoid_em_cache_env_var
branch
from
4017340 to
8fbe634
Compare
This avoid polluting the global environment which makes side-by-side installational of different emscripten version harder. See emscripten-core/emscripten#13954
sbc100
force-pushed
the
avoid_em_cache_env_var
branch
from
8fbe634 to
15bde98
Compare
|
The other nice thing about this change is that folks like me who regularly switch between emsdk and non-emsdk setups have one less thing to do when we switch. After this all I really need to do disable emsdk to to run: I no longer need to run |
kripken
approved these changes
Apr 23, 2021
juj
approved these changes
Apr 26, 2021
sbc100
added a commit
that referenced
this pull request
Apr 27, 2021
When we deactivate a tool we also want to remove its environment variables. One driver for this is that modern sdks don't set `EM_CACHE` whereas old ones did and we want to make sure that `EM_CACHE` gets unset when folks upgrade (and then re-set if they downgrade). See #797.
sbc100
added a commit
that referenced
this pull request
Apr 28, 2021
When we deactivate a tool we also want to remove its environment variables. One driver for this is that modern sdks don't set `EM_CACHE` whereas old ones did and we want to make sure that `EM_CACHE` gets unset when folks upgrade (and then re-set if they downgrade). See #797.
sbc100
added a commit
that referenced
this pull request
Apr 28, 2021
When we deactivate a tool we also want to remove its environment variables. One driver for this is that modern sdks don't set `EM_CACHE` whereas old ones did and we want to make sure that `EM_CACHE` gets unset when folks upgrade (and then re-set if they downgrade). See #797.
sbc100
added a commit
that referenced
this pull request
Apr 28, 2021
When we deactivate a tool we also want to remove its environment variables. One driver for this is that modern sdks don't set `EM_CACHE` whereas old ones did and we want to make sure that `EM_CACHE` gets unset when folks upgrade (and then re-set if they downgrade). See #797.
sbc100
added a commit
that referenced
this pull request
Apr 28, 2021
When we deactivate a tool we also want to remove its environment variables. One driver for this is that modern sdks don't set `EM_CACHE` whereas old ones did and we want to make sure that `EM_CACHE` gets unset when folks upgrade (and then re-set if they downgrade). See #797.
sbc100
added a commit
that referenced
this pull request
Apr 29, 2021
When we deactivate a tool we also want to remove its environment variables. One driver for this is that modern sdks don't set `EM_CACHE` whereas old ones did and we want to make sure that `EM_CACHE` gets unset when folks upgrade (and then re-set if they downgrade). See #797.
radekdoulik
referenced
this pull request
in dotnet/emsdk
May 20, 2021
This avoid polluting the global environment which makes side-by-side installational of different emscripten version harder. See emscripten-core/emscripten#13954
radekdoulik
referenced
this pull request
in dotnet/emsdk
May 20, 2021
When we deactivate a tool we also want to remove its environment variables. One driver for this is that modern sdks don't set `EM_CACHE` whereas old ones did and we want to make sure that `EM_CACHE` gets unset when folks upgrade (and then re-set if they downgrade). See #797.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoid polluting the global environment which makes
side-by-side installational of different emscripten version
harder.
See emscripten-core/emscripten#13954