Unset emsdk-related environment variables from inactive tools #801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should probably write test for this specifically around older SDKs and |
|
In the long run, this change (combined with existing #797) should allow unity to move away from passing |
sbc100
changed the title
sbc100
force-pushed
the
unset_old_env
branch
2 times, most recently
from
9771258 to
1e8edb0
Compare
kripken
reviewed
Apr 28, 2021
When we deactivate a tool we also want to remove its environment variables. One driver for this is that modern sdks don't set `EM_CACHE` whereas old ones did and we want to make sure that `EM_CACHE` gets unset when folks upgrade (and then re-set if they downgrade). See #797.
|
lgtm, though this maybe a good item to throw a notification to mailing list, since this will visibly change the semantics for users. |
radekdoulik
referenced
this pull request
in dotnet/emsdk
May 20, 2021
When we deactivate a tool we also want to remove its environment variables. One driver for this is that modern sdks don't set `EM_CACHE` whereas old ones did and we want to make sure that `EM_CACHE` gets unset when folks upgrade (and then re-set if they downgrade). See #797.
jmglogow
added a commit
to jmglogow/emsdk
that referenced
this pull request
Nov 14, 2021
Introduced in commit b4c9194 ("Unset emsdk-related environment variable from inactive tools (emscripten-core#801)"), but no other match from "git log -GEMSDK_TTY".
jmglogow
added a commit
to jmglogow/emsdk
that referenced
this pull request
Nov 14, 2021
Introduced in commit b4c9194 ("Unset emsdk-related environment variable from inactive tools (emscripten-core#801)"), but no other match from "git log -GEMSDK_TTY".
jmglogow
added a commit
to jmglogow/emsdk
that referenced
this pull request
Nov 28, 2021
Introduced in commit b4c9194 ("Unset emsdk-related environment variable from inactive tools (emscripten-core#801)"), but no other match from "git log -GEMSDK_TTY".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we deactivate a tool we also want to remove its environment
variables. One driver for this is that modern sdks don't set
EM_CACHEwhereas old ones did and we want to make sure thatEM_CACHEgets unset when folks upgrade (and then re-set ifthey downgrade). See #797.