feat: resend message #259
Merged
feat: resend message #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
protocol/resend-messages.md:1
- [nitpick] Consider replacing the placeholder '[Project Name]' with the actual project name for clarity.
# [Project Name]: Design Doc
protocol/resend-messages.md
Outdated
Comment on lines
35
to
36
| A hash collision could occur where different message params result in any valid message sent. This would involve a bug in the `Hashing` library logic or a hash collision, for which it’s likelihood is very low. | ||
|
|
There was a problem hiding this comment.
[nitpick] Consider correcting the contraction 'it’s' to 'its' and rephrasing the sentence for improved clarity.
Suggested change
| A hash collision could occur where different message params result in any valid message sent. This would involve a bug in the `Hashing` library logic or a hash collision, for which it’s likelihood is very low. | |
| A hash collision could occur where different message parameters result in a valid message being sent. This would involve a bug in the `Hashing` library logic or a hash collision, for which its likelihood is very low. |
Copilot uses AI. Check for mistakes.
tynes
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing a new
resendMessageto re-emit theSentMessageevent for a message that was never relayed and became very old for the supervisor to pick it up.Metadata