-
Notifications
You must be signed in to change notification settings - Fork 3.6k
feat: resend message #15300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: resend message #15300
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #15300 +/- ##
===========================================
+ Coverage 78.98% 85.64% +6.65%
===========================================
Files 176 121 -55
Lines 10790 6242 -4548
===========================================
- Hits 8523 5346 -3177
+ Misses 2075 884 -1191
+ Partials 192 12 -180
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Any idea why CI is failing here? cc @maurelian @blmalone. Is it just that the backend is down? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (6)
- packages/contracts-bedrock/interfaces/L2/IL2ToL2CrossDomainMessenger.sol: Language not supported
- packages/contracts-bedrock/snapshots/abi/L2ToL2CrossDomainMessenger.json: Language not supported
- packages/contracts-bedrock/snapshots/semver-lock.json: Language not supported
- packages/contracts-bedrock/snapshots/storageLayout/L2ToL2CrossDomainMessenger.json: Language not supported
- packages/contracts-bedrock/src/L2/L2ToL2CrossDomainMessenger.sol: Language not supported
- packages/contracts-bedrock/test/L2/L2ToL2CrossDomainMessenger.t.sol: Language not supported
@tynes these look to be errors hitting our internal archive nodes: https://ci-mainnet-l1-archive.optimism.io/. @jelias2 do you know of any on going issues with our nodes? |
That url queries 3rd party rpc, I triggered another run on circleci |
* feat: add re emit sent msg event logic on l2 to l2 cdm * feat: add tests for the re emit feature * fix: review comments chore: run pre pr * refactor: rename to resend msg * chore: return msg hash (ethereum-optimism#361) --------- Co-authored-by: 0xDiscotech <[email protected]>
Description
Introducing a new
resendMessage
to re-emit theSentMessage
event for a message that was never relayed and became very old for the supervisor to pick it up.Additional Context
Metadata
Closes #15284
Authored by @0xDiscotech