Skip to content

feat: resend message #15300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 10, 2025
Merged

feat: resend message #15300

merged 5 commits into from
Apr 10, 2025

Conversation

agusduha
Copy link
Contributor

@agusduha agusduha commented Apr 8, 2025

Description

Introducing a new resendMessage to re-emit the SentMessage event for a message that was never relayed and became very old for the supervisor to pick it up.

Additional Context

Metadata

Closes #15284

Authored by @0xDiscotech

@agusduha agusduha requested a review from a team as a code owner April 8, 2025 18:42
@agusduha agusduha requested a review from AmadiMichael April 8, 2025 18:42
@agusduha agusduha changed the title feat: re send msg sent feat: resend message Apr 8, 2025
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.64%. Comparing base (6cce18e) to head (b18b57d).
Report is 30 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15300      +/-   ##
===========================================
+ Coverage    78.98%   85.64%   +6.65%     
===========================================
  Files          176      121      -55     
  Lines        10790     6242    -4548     
===========================================
- Hits          8523     5346    -3177     
+ Misses        2075      884    -1191     
+ Partials       192       12     -180     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests 94.36% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...acts-bedrock/src/L2/L2ToL2CrossDomainMessenger.sol 100.00% <100.00%> (ø)

... and 71 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tynes
Copy link
Contributor

tynes commented Apr 8, 2025

Any idea why CI is failing here? cc @maurelian @blmalone. Is it just that the backend is down?

@tynes tynes requested a review from Copilot April 8, 2025 20:49
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (6)
  • packages/contracts-bedrock/interfaces/L2/IL2ToL2CrossDomainMessenger.sol: Language not supported
  • packages/contracts-bedrock/snapshots/abi/L2ToL2CrossDomainMessenger.json: Language not supported
  • packages/contracts-bedrock/snapshots/semver-lock.json: Language not supported
  • packages/contracts-bedrock/snapshots/storageLayout/L2ToL2CrossDomainMessenger.json: Language not supported
  • packages/contracts-bedrock/src/L2/L2ToL2CrossDomainMessenger.sol: Language not supported
  • packages/contracts-bedrock/test/L2/L2ToL2CrossDomainMessenger.t.sol: Language not supported

@blmalone
Copy link
Contributor

blmalone commented Apr 8, 2025

@tynes these look to be errors hitting our internal archive nodes: https://ci-mainnet-l1-archive.optimism.io/. @jelias2 do you know of any on going issues with our nodes?

@jelias2
Copy link
Contributor

jelias2 commented Apr 8, 2025

@tynes these look to be errors hitting our internal archive nodes: https://ci-mainnet-l1-archive.optimism.io/. @jelias2 do you know of any on going issues with our nodes?

That url queries 3rd party rpc, I triggered another run on circleci

@tynes tynes added this pull request to the merge queue Apr 10, 2025
Merged via the queue into develop with commit d0254ff Apr 10, 2025
51 checks passed
@tynes tynes deleted the feat/re-send-msg-sent branch April 10, 2025 18:01
ClaytonNorthey92 pushed a commit to hemilabs/optimism that referenced this pull request May 13, 2025
* feat: add re emit sent msg event logic on l2 to l2 cdm

* feat: add tests for the re emit feature

* fix: review comments

chore: run pre pr

* refactor: rename to resend msg

* chore: return msg hash (ethereum-optimism#361)

---------

Co-authored-by: 0xDiscotech <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tracking] Messenger Re-emit Initiating Message to be Expiry Proof
6 participants