-
Notifications
You must be signed in to change notification settings - Fork 263
updating l1 timelines #1325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating l1 timelines #1325
Conversation
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThis pull request updates the Ethereum Pectra documentation by revising the hard fork timeline details and client testnet release schedules. The document now references tentative L1 Pectra hard fork times per the ACDC instead of confirmed dates, with updated scheduling information for Holesky and Sepolia. Additionally, the client testnet release information has been streamlined by removing redundant entries and consolidating key dates. In the Possibly related PRs
Suggested reviewers
Tip 🌐 Web search-backed reviews and chat
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pages/builders/notices/pectra-changes.mdx (1)
15-15
: Refine callout phrasing for clarity.
The message "Here's the tentative L1 Pectra hard fork times per the ACDC that happened on Feb 6th:" may benefit from slightly clearer phrasing. Consider rewording it to something like:
"Here's the tentative L1 Pectra hard fork schedule according to the ACDC update from Feb 6th:"
This small adjustment can help clarify that the dates stem from an official update.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
pages/builders/notices/pectra-changes.mdx
(1 hunks)words.txt
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with ...
**/*.mdx
: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
pages/builders/notices/pectra-changes.mdx
🪛 LanguageTool
words.txt
[duplication] ~112-~112: Möglicher Tippfehler: ein Wort wird wiederholt
Context: ... ETHERBASE etherbase Ethernity Ethernow ETHSTATS ethstats EVMTIMEOUT evmtimeout executability exf...
(GERMAN_WORD_REPEAT_RULE)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
- GitHub Check: pr-workflow
🔇 Additional comments (2)
pages/builders/notices/pectra-changes.mdx (1)
17-17
: Confirm updated client testnet release timeline.
The revised line "L1 Client testnet releases out by Feb 13 (ACDE):" is concise and reflects the updated schedule. Please ensure that this new date and acronymous label (ACDE) match internal communications and related documentation.words.txt (1)
112-112
: Verify reintroduction of the "Ethernow" entry.
The entry "Ethernow" has been re-added to the list. Please confirm that this change is intentional and that the term now aligns with the current nomenclature across documentation. Also, double-check that it does not unintentionally duplicate any similar entries (e.g., "Ethernity") if that is not desired.🧰 Tools
🪛 LanguageTool
[duplication] ~112-~112: Möglicher Tippfehler: ein Wort wird wiederholt
Context: ... ETHERBASE etherbase Ethernity Ethernow ETHSTATS ethstats EVMTIMEOUT evmtimeout executability exf...(GERMAN_WORD_REPEAT_RULE)
Description
Tests
Additional context
Metadata