Skip to content

Update pectra-changes.mdx #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update pectra-changes.mdx #1558

wants to merge 1 commit into from

Conversation

sbvegan
Copy link
Collaborator

@sbvegan sbvegan commented Apr 7, 2025

Description

Tests

Additional context

Metadata

@sbvegan sbvegan requested a review from a team as a code owner April 7, 2025 19:44
Copy link

netlify bot commented Apr 7, 2025

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit 13d5e4a
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/67f42b394bbd480008de8202
😎 Deploy Preview https://deploy-preview-1558--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Apr 7, 2025

📝 Walkthrough

Walkthrough

This pull request updates the Ethereum Pectra hard fork documentation. The changes revise key dates and values: the ACDC event is now scheduled for April 3rd (changed from February 6th) and the mainnet hard fork slot has been updated from April 8th to April 17th, 2025, while the testnet release slots for Holesky and Sepolia remain unchanged. Additionally, the document updates the absolute prestate generation version from op-program/v1.5.0-rc.4 to op-program/v1.5.0 and revises the corresponding absolute prestate hash. Expected output hashes for Cannon, Cannon64, and CannonInterop have been modified to reflect the new prestate details.

Possibly related PRs

  • Sb/pectra u12a update #1490: Updates to the absolute prestate version and hash values directly correspond with the document modifications in this PR.
  • pectra notice #1324: Addresses activation times and schedule updates for the Pectra hard fork, aligning with the timeline changes in this PR.
  • updating l1 timelines #1325: Contains modifications to hard fork dates and testnet release slots that are directly related to the updates in this PR.

Suggested reviewers

  • bradleycamacho

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
pages/notices/pectra-changes.mdx (1)

122-122: Absolute Prestate Version and Hash Update

The section now correctly references the use of [op-program/v1.5.0] and displays the updated absolute prestate hash (0x039facea52b20c605c05efb0a33560a92de7074218998f75bcdf61e8989cb5d9). Consider clarifying the terminology—if multiple hash values (for Cannon, Cannon64, and CannonInterop) are being provided later, it may be clearer to refer to these as “absolute prestates.”

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 484f508 and 13d5e4a.

📒 Files selected for processing (1)
  • pages/notices/pectra-changes.mdx (3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with the following criteria: - First, check the frontmatter section at the top of the file: 1. For regular pages, ensure AL...

**/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • First, check the frontmatter section at the top of the file:
    1. For regular pages, ensure ALL these fields are present and not empty:
    ---
    title: [non-empty]
    lang: [non-empty]
    description: [non-empty]
    topic: [non-empty]
    personas: [non-empty array]
    categories: [non-empty array]
    content_type: [valid type]
    ---
    1. For landing pages (index.mdx or files with ), only these fields are required:
    ---
    title: [non-empty]
    lang: [non-empty]
    description: [non-empty]
    topic: [non-empty]
    ---
    1. If any required fields are missing or empty, comment:
      'This file appears to be missing required metadata. Please check keywords.config.yaml for valid options and add the required fields manually. You can validate your changes by running:
    pnpm validate-metadata
    ```'
  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
  • pages/notices/pectra-changes.mdx
🪛 LanguageTool
pages/notices/pectra-changes.mdx

[grammar] ~127-~127: The verb ‘prestate’ is plural. Did you mean: “prestates”? Did you use a verb instead of a noun?
Context: ...Soneium You can verify this absolute prestate by running the following [command](http...

(PLURAL_VERB_AFTER_THIS)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - docs-optimism
  • GitHub Check: Header rules - docs-optimism
  • GitHub Check: Pages changed - docs-optimism
🔇 Additional comments (5)
pages/notices/pectra-changes.mdx (5)

1-16: Frontmatter and Metadata Validity

The frontmatter section includes all required fields (title, description, lang, content_type, topic, personas, categories) and is formatted correctly. Ensure that the extra field is_imported_content is intentionally provided as a string and complies with your metadata schema.


40-41: ACDC Date and Timeline Notification Update

The callout now references the ACDC event taking place on April 3rd, which aligns with the updated schedule. Please verify that this new timing is consistently reflected elsewhere in the document.


44-45: Testnet Release Slot Details Verification

The release slots for Holesky and Sepolia are specified as “Mon, Feb 24 at 21:55:12 UTC” and “Wed, Mar 5 at 07:29:36 UTC,” respectively. However, line 42 still mentions “L1 Client testnet releases out by Feb 13 (ACDE).” Please double-check that these dates are correct and consistent with your intended timeline.


46-46: Mainnet Release Slot Update

The mainnet release slot has been updated to “Thu, Apr 17 16:00:00 UTC 2025,” which is in line with the new schedule detailed in the AI summary. This change appears correct.


136-141: Updated Absolute Prestate Hashes

The updated hashes for Cannon, Cannon64, and CannonInterop are shown as follows:

  • Cannon: 0x039facea52b20c605c05efb0a33560a92de7074218998f75bcdf61e8989cb5d9
  • Cannon64: 0x039970872142f48b189d18dcbc03a3737338d098b0101713dc2d6710f9deb5ef
  • CannonInterop: 0x03a806c966e97816f1ff8d4f04a8ec823099e8f9c32e1d0cfca814f545b85115

These updates correspond with the revised prestate details and appear accurate. Please ensure that these values remain consistent with all other prestate references within the documentation.

@sbvegan
Copy link
Collaborator Author

sbvegan commented Apr 7, 2025

will clarify which absolute prestates to use in the U15 notice doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant