-
Notifications
You must be signed in to change notification settings - Fork 262
Update pectra-changes.mdx #1558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThis pull request updates the Ethereum Pectra hard fork documentation. The changes revise key dates and values: the ACDC event is now scheduled for April 3rd (changed from February 6th) and the mainnet hard fork slot has been updated from April 8th to April 17th, 2025, while the testnet release slots for Holesky and Sepolia remain unchanged. Additionally, the document updates the absolute prestate generation version from Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pages/notices/pectra-changes.mdx (1)
122-122
: Absolute Prestate Version and Hash UpdateThe section now correctly references the use of [op-program/v1.5.0] and displays the updated absolute prestate hash (
0x039facea52b20c605c05efb0a33560a92de7074218998f75bcdf61e8989cb5d9
). Consider clarifying the terminology—if multiple hash values (for Cannon, Cannon64, and CannonInterop) are being provided later, it may be clearer to refer to these as “absolute prestates.”
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pages/notices/pectra-changes.mdx
(3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with the following criteria: - First, check the frontmatter section at the top of the file: 1. For regular pages, ensure AL...
**/*.mdx
: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- First, check the frontmatter section at the top of the file:
- For regular pages, ensure ALL these fields are present and not empty:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] personas: [non-empty array] categories: [non-empty array] content_type: [valid type] ---
- For landing pages (index.mdx or files with ), only these fields are required:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] ---
- If any required fields are missing or empty, comment:
'This file appears to be missing required metadata. Please check keywords.config.yaml for valid options and add the required fields manually. You can validate your changes by running:pnpm validate-metadata ```'
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
pages/notices/pectra-changes.mdx
🪛 LanguageTool
pages/notices/pectra-changes.mdx
[grammar] ~127-~127: The verb ‘prestate’ is plural. Did you mean: “prestates”? Did you use a verb instead of a noun?
Context: ...Soneium You can verify this absolute prestate by running the following [command](http...
(PLURAL_VERB_AFTER_THIS)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
🔇 Additional comments (5)
pages/notices/pectra-changes.mdx (5)
1-16
: Frontmatter and Metadata ValidityThe frontmatter section includes all required fields (title, description, lang, content_type, topic, personas, categories) and is formatted correctly. Ensure that the extra field
is_imported_content
is intentionally provided as a string and complies with your metadata schema.
40-41
: ACDC Date and Timeline Notification UpdateThe callout now references the ACDC event taking place on April 3rd, which aligns with the updated schedule. Please verify that this new timing is consistently reflected elsewhere in the document.
44-45
: Testnet Release Slot Details VerificationThe release slots for Holesky and Sepolia are specified as “Mon, Feb 24 at 21:55:12 UTC” and “Wed, Mar 5 at 07:29:36 UTC,” respectively. However, line 42 still mentions “L1 Client testnet releases out by Feb 13 (ACDE).” Please double-check that these dates are correct and consistent with your intended timeline.
46-46
: Mainnet Release Slot UpdateThe mainnet release slot has been updated to “Thu, Apr 17 16:00:00 UTC 2025,” which is in line with the new schedule detailed in the AI summary. This change appears correct.
136-141
: Updated Absolute Prestate HashesThe updated hashes for Cannon, Cannon64, and CannonInterop are shown as follows:
- Cannon:
0x039facea52b20c605c05efb0a33560a92de7074218998f75bcdf61e8989cb5d9
- Cannon64:
0x039970872142f48b189d18dcbc03a3737338d098b0101713dc2d6710f9deb5ef
- CannonInterop:
0x03a806c966e97816f1ff8d4f04a8ec823099e8f9c32e1d0cfca814f545b85115
These updates correspond with the revised prestate details and appear accurate. Please ensure that these values remain consistent with all other prestate references within the documentation.
will clarify which absolute prestates to use in the U15 notice doc |
Description
Tests
Additional context
Metadata