Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State of Tic Tac Toe: test 8 is an invalid game #1127

Closed
chriseyre2000 opened this issue May 1, 2022 · 5 comments
Closed

State of Tic Tac Toe: test 8 is an invalid game #1127

chriseyre2000 opened this issue May 1, 2022 · 5 comments

Comments

@chriseyre2000
Copy link
Contributor

Test 8 has the following test data

"O.O\nXXX\n.O.\n" which is an invalid game as X won before O's last turn
@jiegillet
Copy link
Contributor

You're right, and we can fix it by removing (let's say) the very first O.
Could you open an issue/PR on problem-specifications as well? I will approve it.

@chriseyre2000
Copy link
Contributor Author

I was going to do that and add one more test with a continue past without a second win.

@jiegillet
Copy link
Contributor

Great! To be as consistent as possible, let's wait for the specs to change before updating the tests here.

@chriseyre2000
Copy link
Contributor Author

Raised the problem specification as an issue:

exercism/problem-specifications#2030

Only fixing the direct problem. I am now going to raise a PR to fix it.

chriseyre2000 added a commit to chriseyre2000/problem-specifications that referenced this issue May 1, 2022
@chriseyre2000
One of the test cases has too many O's
b5a9b0e 
The test case has been won by X yet there are the same number of X's and O's.
This fixes this issue: exercism/elixir#1127
@chriseyre2000 chriseyre2000 mentioned this issue May 1, 2022
Merged
jiegillet pushed a commit to exercism/problem-specifications that referenced this issue May 1, 2022
@chriseyre2000
One of the test cases has too many O's (#2031)
56eed39 
* One of the test cases has too many O's

The test case has been won by X yet there are the same number of X's and O's.
This fixes this issue: exercism/elixir#1127

* Updated uuid

Changed UUID for one test to allow test to pass.

* Reimplemented a test case

The existing test was invalid.

* It was an O not an 0

Fixed typo
@angelikatyborska
Copy link
Member

Fixed in #1129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chriseyre2000 @angelikatyborska @jiegillet